Skip to content

RUST-1748 Convert UUID serde helpers to use serde_conv #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JamieTsai1024 merged 70 commits into from
Jul 23, 2025
Merged

RUST-1748 Convert UUID serde helpers to use serde_conv #579

JamieTsai1024 merged 70 commits into from
Jul 23, 2025

Conversation

@JamieTsai1024
Copy link
Contributor

@JamieTsai1024 JamieTsai1024 commented Jul 22, 2025

Converted UUID functions in src/serde_helpers.rs to use serde_conv macro for serializing and deserializing optional and vector fields with serde_with.

  • Added tests for <T>, Option<T>, and Vec<T> fields (de)serialized using converter structs
  • Added documentation for modules and structs
Old New
uuid_1_as_binary uuid_1::AsBinary (UUID → Timestamp)
uuid_1_as_c_sharp_legacy_binary uuid_1::AsCSharpLegacyBinary (UUID → Binary)
uuid_1_as_java_legacy_binary uuid_1::AsJavaLegacyBinary (UUID → Binary)
uuid_1_as_python_legacy_binary uuid_1::AsPythonLegacyBinary (UUID → Binary)

Previously:

  • Rewrote serde converters as structs with SerializeAs and DeserializeAs traits to support Optional and Vector conversions in PR #559
  • Adapted serde_conv macro to support Rustdocs, refactored all ObjectId converters in PR #566
  • Refactored all DateTime converters in PR #570
  • Converted all unsigned (u32 and u64) helpers in PR #575
  • Added rustdoc documentation to ObjectId converters in PR #578

@JamieTsai1024
Refactor BSON DateTime serde converters using serde_conv_doc macro
a54433e
@JamieTsai1024
Refactor OffsetDateTime and i64 to DateTime helpers to use serde_conv
a51f29e
@JamieTsai1024
Refactor type converters betweem timestamp and u32 with serde_conv
03e9a51
@JamieTsai1024
Refactor u32 and u64 to f64 converters to use serde_conv
f1577fd
@JamieTsai1024
Rename u32 module to timestamp
b8ad904
@JamieTsai1024
Clean up remaining u32_as_timestamp converter
a1ad2de
@JamieTsai1024
Fix struct capitalization
5529ec8
@JamieTsai1024
Refactor unsigned (u32, u64) to signed (i32, i64) converters using se…
a7c182a 
…rde_conv
@JamieTsai1024
Consolidate module names under u32 and u64
693faa8
@JamieTsai1024
Consolidate module names under u32 and u64
a9873d3
@JamieTsai1024
Refactor uuid to binary converter to use serde_conv
b9b08cf
@JamieTsai1024
Reorder tests based on serde_helpers ordering
1ccea32
@JamieTsai1024
Refactor uuid to legacy binary converters using serde_conv
1db7343
@JamieTsai1024
Shorten vector field assertions
4cdaf4b
@JamieTsai1024
Remove unused imports
61e2b05
@JamieTsai1024
Shorten deserialization assertions
b566c08
@JamieTsai1024
Add documentation for modules
181bcd2
@JamieTsai1024
Reorder imports in documentation
ed526cb
@JamieTsai1024
Shorten *_optional_some field assertions
a63f82e
@JamieTsai1024
Remove bson from datetime helpers module name
2298c43
@JamieTsai1024
Add RFC 3339 format to error messages
7cdc3d9
@JamieTsai1024
Fix typo
76349a0
@JamieTsai1024
Fix typo 'DatetTime'
4e4291e
@JamieTsai1024
Refactor DateTime FromI64 and FromTime03OffsetDateTime using serde_co…
e9b14b8 
…nv macro
@JamieTsai1024
Add rustdoc comments to module and structs
212ea0b
@JamieTsai1024
Switch from clone through to_owned() to dereference
03027d1
@JamieTsai1024
Rename bson_datetime module to datetime
7077c0b
@JamieTsai1024
Remove extra rustdocs ///
ebe3a99
@JamieTsai1024
Add DateTime import to fix lint on rustdocs
9f41ee6
@JamieTsai1024
Merge branch 'RUST-1748-serde_conv-2' into RUST-1748-serde_conv-3
e6b69c5
@JamieTsai1024
Undo uncommenting rustdocs
6f74ead
@JamieTsai1024
Fix clippy attempt - move conditional compilation attribute
a3dd1b8
@JamieTsai1024
Revert all ObjectId changes (separate to another PR)
f81dfd2
@JamieTsai1024
Revert "Revert all ObjectId changes (separate to another PR)"
d3eb97e 
This reverts commit f81dfd2.
@JamieTsai1024
Move #[cfg(feature = serde_with-3)] attribute to test function
60b6c4f
@JamieTsai1024
Break tests into smaller functions
d91ba76
@JamieTsai1024
Remove whitespace diffs
de0b400
@JamieTsai1024
Merge branch 'RUST-1748-serde_conv-2' into RUST-1748-serde_conv-3
844b50c
@JamieTsai1024
Merge branch 'RUST-1748-serde_conv-3' into RUST-1748-serde_conv-3.5
e9334c5
@JamieTsai1024
Merge branch 'RUST-1748-serde_conv-3.5' into RUST-1748-serde_conv-4
93d8efe
@JamieTsai1024
Fix whitespace
6d4951c
@JamieTsai1024
Merge branch 'RUST-1748-serde_conv-3.5' into RUST-1748-serde_conv-4
26419ad
@JamieTsai1024
Fix rustdocs whitespace
5ca198f
@JamieTsai1024
Fix rustdocs whitespace and imports
29b289a
@JamieTsai1024
Merge branch 'RUST-1748-serde_conv-3.5' into RUST-1748-serde_conv-4
57a763b
@JamieTsai1024
Update rustdocs
25324ca
@JamieTsai1024
Fix rustdoc imports
fbe3bfc
@JamieTsai1024
Merge branch 'main' into RUST-1748-serde_conv-4
9087456
@JamieTsai1024
Add back missing uuid tests lost in PR split
b0d6844
@JamieTsai1024
Remove Result imports in tests
43f94a1
@JamieTsai1024
Fix lint with Binary unused import
b892c34
@JamieTsai1024 JamieTsai1024 marked this pull request as ready for review July 22, 2025 16:45
@JamieTsai1024 JamieTsai1024 requested a review from a team as a code owner July 22, 2025 16:45
@JamieTsai1024 JamieTsai1024 requested a review from abr-egn July 22, 2025 17:02
isabelatkinson
isabelatkinson reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a doc fix!

isabelatkinson
isabelatkinson approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@JamieTsai1024 JamieTsai1024 merged commit 266aa30 into mongodb:main Jul 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isabelatkinson isabelatkinson isabelatkinson approved these changes

@abr-egn abr-egn Awaiting requested review from abr-egn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamieTsai1024 @isabelatkinson