RUST-1748 Convert serde helpers to serde_with::(De)SerializeAs implementations #559
+748
−231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
requested review from
isabelatkinson
and removed request for
abr-egn
isabelatkinson
requested changes
Jun 26, 2025
src/tests/serde.rs
Outdated
Comment on lines
804
to
812
| for element in date_vector { | ||
| match element { | ||
| bson::Bson::String(value) => assert_eq!( | ||
| value, iso, | ||
| "Expected each element in date_vector to match original.", | ||
| ), | ||
| _ => panic!("Expected all elements in date_vector to be a BSON DateTime."), | ||
| } | ||
| } |
There was a problem hiding this comment.
can this be assert_eq!(date_vector, a.date_vector) instead?
There was a problem hiding this comment.
I was trying to find a cleaner version of using assert_eq and this is the best I could come up with - it just has less detailed error messages. Do you have any feedback on this before I use it for the other tests?
let date_vector = doc
.get_array("date_vector")
.expect("Expected serialized date_vector to be a BSON array.");
let expected_date_vector: Vec<Bson> = a
.date_vector
.iter()
.map(|dt| Bson::String(dt.try_to_rfc3339_string().unwrap()))
.collect();
assert_eq!(date_vector, &expected_date_vector);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.