Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to perform tarball dry-run #308
feat: add ability to perform tarball dry-run #308
Changes from 1 commit
4dc0e5b
a9dc278
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why
process.nextTick
is necessary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention here is to turn unhandled Promise rejections (which print a warning but do not result in the process exiting with a non-zero exit code) into an uncaught exception (which does result in the process exiting with code 1) – that behavior has a long, long history of debate behind it, and Node.js core will most likely change it in the future (https://medium.com/@nodejs/node-js-promise-reject-use-case-survey-98e3328340c9 has some futher reading on the current state of things, if you’re curious)
If this was re-throwing the error directly, it would just create another rejected Promise, so this is using
process.nextTick()
to make this independent of the Promise chain and avoid that