feat: add ability to perform tarball dry-run #308
Conversation
Provide an easy way to create distribution tarballs without also uploading them for testing.
| }); | ||
| runRelease().then( | ||
| () => process.exit(0), | ||
| (err) => process.nextTick(() => { throw err; })); |
There was a problem hiding this comment.
Just curious why process.nextTick is necessary?
There was a problem hiding this comment.
The intention here is to turn unhandled Promise rejections (which print a warning but do not result in the process exiting with a non-zero exit code) into an uncaught exception (which does result in the process exiting with code 1) – that behavior has a long, long history of debate behind it, and Node.js core will most likely change it in the future (https://medium.com/@nodejs/node-js-promise-reject-use-case-survey-98e3328340c9 has some futher reading on the current state of things, if you’re curious)
If this was re-throwing the error directly, it would just create another rejected Promise, so this is using process.nextTick() to make this independent of the Promise chain and avoid that
Provide an easy way to create distribution tarballs without also
uploading them for testing.