Skip to content

chore: disable telemetry in accuracy tests #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

chore: disable telemetry in accuracy tests #704

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76cd719
chore: disable telemetry in accuracy tests
nirinchev Oct 28, 2025
0ad5c58
pass in the process env
nirinchev Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/accuracy/sdk/accuracyTestingClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,14 @@ export class AccuracyTestingClient {
return [`--${key}`, value];
});

const args = [MCP_SERVER_CLI_SCRIPT, "--connectionString", mdbConnectionString, ...additionalArgs];
const args = [MCP_SERVER_CLI_SCRIPT, mdbConnectionString, ...additionalArgs];
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the --connectionString flag changes the CLI argument structure. The connection string is now passed as a positional argument instead of a named parameter. If the CLI expects --connectionString <value>, this will cause the server to fail to start or misinterpret arguments.

Suggested change
const args = [MCP_SERVER_CLI_SCRIPT, mdbConnectionString, ...additionalArgs];
const args = [MCP_SERVER_CLI_SCRIPT, "--connectionString", mdbConnectionString, ...additionalArgs];

Copilot uses AI. Check for mistakes.

const clientTransport = new StdioClientTransport({
command: process.execPath,
args,
env: {
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The env object should include the existing environment variables to avoid breaking other functionality that may depend on them. Use { ...process.env, DO_NOT_TRACK: "1" } to preserve the parent process environment.

Suggested change
env: {
env: {
...process.env,

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with Copilot

DO_NOT_TRACK: "1",
},
});

const client = await createMCPClient({
Expand Down
1 change: 0 additions & 1 deletion tests/integration/elicitation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { describeWithMongoDB } from "./tools/mongodb/mongodbHelpers.js";
function createTestConfig(config: Partial<UserConfig> = {}): UserConfig {
return {
...defaultTestConfig,
telemetry: "disabled",
// Add fake API credentials so Atlas tools get registered
apiClientId: "test-client-id",
apiClientSecret: "test-client-secret",
Expand Down
Loading