chore: disable telemetry in accuracy tests #704
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR disables telemetry in accuracy tests by setting the DO_NOT_TRACK environment variable and removes the --connectionString flag from the MCP server CLI arguments.
- Removes
telemetry: "disabled"from integration test configuration - Adds
DO_NOT_TRACK: "1"environment variable to accuracy test client - Removes
--connectionStringflag from CLI arguments in accuracy tests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/integration/elicitation.test.ts | Removes explicit telemetry disabling from test configuration |
| tests/accuracy/sdk/accuracyTestingClient.ts | Sets DO_NOT_TRACK environment variable and removes --connectionString flag from CLI args |
| }); | ||
|
|
||
| const args = [MCP_SERVER_CLI_SCRIPT, "--connectionString", mdbConnectionString, ...additionalArgs]; | ||
| const args = [MCP_SERVER_CLI_SCRIPT, mdbConnectionString, ...additionalArgs]; |
There was a problem hiding this comment.
Removing the --connectionString flag changes the CLI argument structure. The connection string is now passed as a positional argument instead of a named parameter. If the CLI expects --connectionString <value>, this will cause the server to fail to start or misinterpret arguments.
| const args = [MCP_SERVER_CLI_SCRIPT, mdbConnectionString, ...additionalArgs]; | |
| const args = [MCP_SERVER_CLI_SCRIPT, "--connectionString", mdbConnectionString, ...additionalArgs]; |
| const clientTransport = new StdioClientTransport({ | ||
| command: process.execPath, | ||
| args, | ||
| env: { |
There was a problem hiding this comment.
The env object should include the existing environment variables to avoid breaking other functionality that may depend on them. Use { ...process.env, DO_NOT_TRACK: "1" } to preserve the parent process environment.
| env: { | |
| env: { | |
| ...process.env, |
Proposed changes
Checklist