This repository was archived by the owner on May 31, 2022. It is now read-only.
COMPASS-4017: Update driver and cleanup #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
There was a problem hiding this comment.
It looks like driver's parseConnectionString function works differently at mongodb/lib/core and mongodb-core packages. const parseConnectionString = require('mongodb/lib/core').parseConnectionString; returns defaultDatabase=test, before defaultDatabase was not specified.
- mongodb-js/compass#1873 is upgrading electron - mongodb-js-fmt is deprecated
Move away from `lodash.*` to top-level `lodash` that is far easier to maintain.
imlucas
added a commit
to mongodb-js/data-service
that referenced
this pull request
Jan 6, 2020
imlucas
added a commit
to mongodb-js/data-service
that referenced
this pull request
Jan 6, 2020
* chore: Cleanup - update dependencies - remove currently unused `electron-rebuild` - remove `pre-commit` from package.json as its logic is now bundled into `mongodb-js-precommit` * refactor: Collapse lodash dependency Move away from `lodash.*` to top-level `lodash` that is far easier to maintain. * chore: Allow mongodb-security semver to update automatically * chore: connection-model update for kerberos electron 6 fix mongodb-js/connection-model#210 * fix(test): No idea how this test ever actually passed before... ✅ * feat(ci): Default test is now electron renderer So we can catch mismatched behaviors in the future as NODE-2387 uncovered * chore: update mongodb-runner mongodb-js/runner#158 * docs: Add note to README that tests now run via electron-mocha
34 tasks
gribnoysup
pushed a commit
to mongodb-js/compass
that referenced
this pull request
Apr 26, 2021
* chore: Cleanup - update dependencies - remove currently unused `electron-rebuild` - remove `pre-commit` from package.json as its logic is now bundled into `mongodb-js-precommit` * refactor: Collapse lodash dependency Move away from `lodash.*` to top-level `lodash` that is far easier to maintain. * chore: Allow mongodb-security semver to update automatically * chore: connection-model update for kerberos electron 6 fix mongodb-js/connection-model#210 * fix(test): No idea how this test ever actually passed before... ✅ * feat(ci): Default test is now electron renderer So we can catch mismatched behaviors in the future as NODE-2387 uncovered * chore: update mongodb-runner mongodb-js/runner#158 * docs: Add note to README that tests now run via electron-mocha
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mongodb-coreis deprecated and merged back intomongodblodash.*to top-levellodashdependency that is far easier to maintain.Motivation and Context
Open Questions