INT-591 only hide *.system.* collections
#160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2015 13:00
make specialish collections darker.
|
Also added a title tip for all collections so that too long names can still be shown. The special collections that we are not filtering out now also have "(internal collection)" added in the title tip.
|
rueckstiess
changed the title
*.system.* collections*.system.* collections
|
@rueckstiess switched to Removed color change on hover for special collections. lgtm |
|
|
imlucas
added a commit
that referenced
this pull request
Oct 15, 2015
INT-591 only hide `*.system.*` collections
gribnoysup
pushed a commit
that referenced
this pull request
Apr 26, 2021
* chore: Cleanup - update dependencies - remove currently unused `electron-rebuild` - remove `pre-commit` from package.json as its logic is now bundled into `mongodb-js-precommit` * refactor: Collapse lodash dependency Move away from `lodash.*` to top-level `lodash` that is far easier to maintain. * chore: Allow mongodb-security semver to update automatically * chore: connection-model update for kerberos electron 6 fix mongodb-js/connection-model#210 * fix(test): No idea how this test ever actually passed before... ✅ * feat(ci): Default test is now electron renderer So we can catch mismatched behaviors in the future as NODE-2387 uncovered * chore: update mongodb-runner mongodb-js/runner#158 * docs: Add note to README that tests now run via electron-mocha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also makes specialish collections darker. (please review @marcgurney)
One small issue I found with this: If a database only contains a
system.*collection (e.g.system.indexes), because all other real collections were deleted, it counts towards the DB count but does not show up in the collection list.I wouldn't change the DB count though. The number it shows is correct, and anyone running "show dbs" will get the same count.