Skip to content

chore: fix remaining missing deps #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2021
Merged

chore: fix remaining missing deps #2262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcdc85a
chore(monorepo): add missing compass deps
mcasimir Jun 17, 2021
7dc6bba
add missing deps
mcasimir Jun 17, 2021
58499a7
chore: fix missing deps
mcasimir Jun 17, 2021
19c475b
regen package lock
mcasimir Jun 17, 2021
8c7a01e
add missing pkg-up
mcasimir Jun 17, 2021
14d8fdc
regen package-lock
mcasimir Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 81 additions & 1 deletion package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions packages/compass-aggregations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
"async": "^1.5.2",
"autoprefixer": "^9.4.10",
"babel-loader": "^8.2.2",
"brace": "^0.11.1",
"bootstrap": "https://github.com/twbs/bootstrap/archive/v3.3.5.tar.gz",
"bson-transpilers": "^0.14.0",
"chai": "^4.2.0",
Expand All @@ -87,6 +88,7 @@
"font-awesome": "^4.7.0",
"hadron-app": "^4.2.1",
"hadron-app-registry": "^8.2.0",
"hadron-document": "^7.2.0",
"hadron-react-bson": "^5.2.0",
"hadron-react-buttons": "^5.2.0",
"hadron-react-components": "^5.2.0",
Expand Down
4 changes: 3 additions & 1 deletion packages/compass-connect/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@
"webpack-merge": "^4.2.1",
"webpack-node-externals": "^3.0.0",
"webpack-sources": "1.4.3",
"xvfb-maybe": "^0.2.1"
"xvfb-maybe": "^0.2.1",
"debug": "^4.1.0",
"lodash.isempty": "^4.4.0"
},
"dependencies": {
"@leafygreen-ui/button": "^11.0.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-explain-plan/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@mongodb-js/compass-status": "^4.2.1",
"d3": "3.5.17",
"debug": "*",
"hadron-document": "^6.2.1",
"hadron-document": "*",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing this to *?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the peer dep section, just noticed that the version here didn't match the one in the devDeps .. but wait lerna should have pick this up right? I'm going to merge it cause this should not cause a problem and try to look into these misaligned stuff later

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lerna doesn't modify peerDeps unfortunately, no. Yeah, thinking it over it's probably even better to set it to * to prevent them from going out of sync, having a specific version in peers seems to be an annoyance already (see #2261 mongodb-js/vscode#301)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw … I think we’ll want to have a "mongodb": "4.x" peer dep in mongodb-connection-model and mongodb-data-service eventually… of course, * would also make this work :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for the feedback you both! After this one I can put * for peer deps for internal deps only, for other deps I guess is fine to have any version range it makes sense as long as they align, lerna would not do anything about them anyway.

Copy link
Collaborator

@gribnoysup gribnoysup Jun 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, totally makes sense @addaleax!

I should've been more specific: I was thinking only about peerDeps between packages that are part of the monorepo, I think for them peerDeps are more of an annoyance than any help and maybe we can move them from peers to direct dependencies, especially taking into account that by default npm7 will be installing them

"hadron-react-bson": "^4.1.1",
"hadron-react-buttons": "^4.1.1",
"hadron-react-components": "^4.1.1",
Expand Down
1 change: 1 addition & 0 deletions packages/compass-home/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@
"mongodb-connection-model": "^20.2.0",
"mongodb-data-service": "^20.2.1",
"mongodb-instance-model": "^11.2.1",
"mongodb-ns": "^2.2.0",
"mongodb-reflux-store": "^0.0.1",
"mongodb-schema": "^8.2.3",
"node-loader": "^0.6.0",
Expand Down
5 changes: 4 additions & 1 deletion packages/compass-import-export/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@
"webpack-merge": "^4.2.2",
"webpack-node-externals": "^3.0.0",
"webpack-sources": "^1.4.3",
"xvfb-maybe": "^0.2.1"
"xvfb-maybe": "^0.2.1",
"mongodb-ns": "^2.2.0",
"brace": "^0.11.1",
"lodash": "^4.17.21"
},
"dependencies": {
"JSONStream": "^1.3.5",
Expand Down
3 changes: 2 additions & 1 deletion packages/compass-query-bar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,8 @@
"webpack-merge": "^4.2.2",
"webpack-node-externals": "^3.0.0",
"webpack-sources": "^1.4.3",
"xvfb-maybe": "^0.2.1"
"xvfb-maybe": "^0.2.1",
"brace": "^0.11.1"
},
"dependencies": {
"lodash": "^4.17.15",
Expand Down
6 changes: 5 additions & 1 deletion packages/compass-query-history/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@
"webpack-dev-server": "^3.11.2",
"webpack-merge": "^4.2.1",
"webpack-node-externals": "^3.0.0",
"webpack-sources": "^1.0.1"
"webpack-sources": "^1.0.1",
"mongodb-ns": "^2.2.0",
"ampersand-rest-collection": "^6.0.0",
"ampersand-model": "^8.0.1",
"uuid": "^3.1.0"
}
}
5 changes: 5 additions & 0 deletions packages/compass-schema-validation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
"@mongodb-js/compass-status": "^5.2.1",
"autoprefixer": "^9.4.6",
"babel-loader": "^8.2.2",
"brace": "^0.11.1",
"bootstrap": "https://github.com/twbs/bootstrap/archive/v3.3.5.tar.gz",
"bson": "4.1.0",
"chai": "^4.1.2",
Expand All @@ -72,6 +73,7 @@
"core-js": "^3.12.1",
"cross-env": "^7.0.0",
"css-loader": "^4.3.0",
"debug": "^4.1.0",
"depcheck": "^1.4.0",
"electron": "^6.1.12",
"electron-rebuild": "^1.10.1",
Expand All @@ -88,13 +90,15 @@
"hadron-react-bson": "^5.2.0",
"hadron-react-buttons": "^5.2.0",
"hadron-react-components": "^5.2.0",
"hadron-document": "^7.2.0",
"html-webpack-plugin": "^3.2.0",
"ignore-loader": "^0.1.2",
"istanbul-instrumenter-loader": "^3.0.0",
"jsdom": "^16.6.0",
"jsdom-global": "^3.0.2",
"less": "^2.7.2",
"less-loader": "^5.0.0",
"lodash.includes": "^4.3.0",
"mocha": "^5.0.0",
"mocha-webpack": "^2.0.0-beta.0",
"mongodb-ace-autocompleter": "^0.6.0",
Expand All @@ -105,6 +109,7 @@
"mongodb-data-service": "^20.2.1",
"mongodb-extended-json": "^1.11.0",
"mongodb-query-parser": "^2.1.1",
"mongodb-ns": "^2.2.0",
"mongodb-reflux-store": "^0.0.1",
"mongodb-schema": "^8.2.5",
"node-loader": "^0.6.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/compass-schema/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@
"webpack-merge": "^4.2.1",
"webpack-node-externals": "^3.0.0",
"webpack-sources": "^1.0.1",
"xvfb-maybe": "^0.2.1"
"xvfb-maybe": "^0.2.1",
"lodash": "^4.17.21"
},
"dependencies": {
"leaflet": "^1.5.1",
Expand Down
5 changes: 5 additions & 0 deletions packages/compass/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,10 @@
"keytar": "^5.1.0",
"less": "^2.6.1",
"local-links": "^1.4.0",
"lodash.assign": "^ 3.2.0",
"lodash.defaults": "^3.1.2",
"lodash.clone": "^3.0.3",
"lodash.includes": "^3.1.3",
"make-fetch-happen": "^8.0.14",
"marky": "^1.2.0",
"moment": "^2.10.6",
Expand All @@ -334,6 +338,7 @@
"mongodb-query-util": "^0.2.1",
"mongodb-schema": "^8.2.5",
"mongodb-shell-to-url": "^0.1.0",
"mongodb-url": "^3.0.3",
"ms": "^0.7.1",
"numeral": "^1.5.3",
"pluralize": "^1.2.1",
Expand Down
4 changes: 3 additions & 1 deletion packages/databases-collections/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,9 @@
"webpack-merge": "^4.2.2",
"webpack-node-externals": "^3.0.0",
"webpack-sources": "^1.4.3",
"xvfb-maybe": "^0.2.1"
"xvfb-maybe": "^0.2.1",
"mongodb-ns": "^2.2.0",
"@leafygreen-ui/icon-button": "^9.1.5"
},
"dependencies": {
"@leafygreen-ui/badge": "^4.0.4",
Expand Down
1 change: 1 addition & 0 deletions packages/hadron-build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
"node-abi": "^2.14.0",
"normalize-package-data": "^2.3.5",
"parse-github-repo-url": "^1.0.0",
"pkg-up": "^3.1.0",
"semver": "^5.1.0",
"tar-pack": "^3.3.0",
"which": "^2.0.2",
Expand Down
0 scripts/monorepo/build-depcheck-report.js → scripts/monorepo/depcheck-report.js
View file
Open in desktop
File renamed without changes.
14 changes: 6 additions & 8 deletions scripts/monorepo/generate-missing-deps-command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,16 @@ const missing = report.filter((p) => Object.keys(p.depcheck.missing).length)


const versions = {
"reflux": "^0.4.1",
"reflux-state-mixin": "github:mongodb-js/reflux-state-mixin",
"mongodb-reflux-store": "^0.0.1",
"mongodb": "^3.6.3",
"mongodb-connection-model": "^20.1.0"
"brace": "^0.11.1",
"mongodb-ns": "^2.2.0",
"debug": "^4.1.0"
}

for (const m of missing) {
for (const dep of Object.keys(m.missing)) {
// if (!versions[dep]) {
// continue;
// }
if (!versions[dep]) {
continue;
}

console.log('\n');
for (const file of m.missing[dep]) {
Expand Down