chore: fix remaining missing deps #2262
Conversation
mcasimir
changed the title
mcasimir
force-pushed
the
fix-remaining-missing-deps
branch
from
e63eb36 to
5b7cfb6
Compare
mcasimir
force-pushed
the
fix-remaining-missing-deps
branch
from
5b7cfb6 to
19c475b
Compare
| @@ -35,7 +35,7 @@ | |||
| "@mongodb-js/compass-status": "^4.2.1", | |||
| "d3": "3.5.17", | |||
| "debug": "*", | |||
| "hadron-document": "^6.2.1", | |||
| "hadron-document": "*", | |||
There was a problem hiding this comment.
Why changing this to *?
There was a problem hiding this comment.
that's the peer dep section, just noticed that the version here didn't match the one in the devDeps .. but wait lerna should have pick this up right? I'm going to merge it cause this should not cause a problem and try to look into these misaligned stuff later
There was a problem hiding this comment.
Lerna doesn't modify peerDeps unfortunately, no. Yeah, thinking it over it's probably even better to set it to * to prevent them from going out of sync, having a specific version in peers seems to be an annoyance already (see #2261 mongodb-js/vscode#301)
There was a problem hiding this comment.
Fwiw … I think we’ll want to have a "mongodb": "4.x" peer dep in mongodb-connection-model and mongodb-data-service eventually… of course, * would also make this work :)
There was a problem hiding this comment.
Ok, thanks for the feedback you both! After this one I can put * for peer deps for internal deps only, for other deps I guess is fine to have any version range it makes sense as long as they align, lerna would not do anything about them anyway.
There was a problem hiding this comment.
Ah, yeah, totally makes sense @addaleax!
I should've been more specific: I was thinking only about peerDeps between packages that are part of the monorepo, I think for them peerDeps are more of an annoyance than any help and maybe we can move them from peers to direct dependencies, especially taking into account that by default npm7 will be installing them
No description provided.