Re-introduce runtime aliases #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed snake_case aliases for client properties here: #314. This commit re-introduces the aliases, this time unenumerable and non-existent in the TypeScript types.
We removed aliases for endpoints here: #315. This commit re-introduces the aliases, this time unenumerable and non-existent in the TypeScript types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed snake_case aliases for client properties and aliases for endpoints. This PR re-introduces them, this time unenumerable and non-existent in the TypeScript types.
This will not do much for TypeScript users, they will still get a compile-time error. This merely affects JavaScript users who are still using deprecated aliases. See #319 for more discussion on this.