Remove snake_case client properties #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The snake case client properties (such as customers_payments) were renamed to dromedary case (such as customerPayments) a while ago. See #223 The first version to include this rename is 3.6.0, released on 10 February 2022. This commit removes the snake case aliases which were added for backwards compatibility.
Pimm
added a commit
that referenced
this pull request
Jul 9, 2024
We removed snake_case aliases for client properties here: #314. This commit re-introduces the aliases, this time unenumerable and non-existent in the TypeScript types.
Pimm
added a commit
that referenced
this pull request
Jul 9, 2024
We removed snake_case aliases for client properties here: #314. This commit re-introduces the aliases, this time unenumerable and non-existent in the TypeScript types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snake case client properties (such as
customers_payments) were renamed to dromedary case (such ascustomerPayments) a while ago. The first version to include this rename is 3.6.0, released on 10 February 2022.The snake case naming doesn't fit in with the JavaScript ecosystem, and is even inconsistent with the rest of the library.
This commit removes the snake case aliases.
The change is breaking. The next release will be 4.0.0.