Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dromedaryCased client properties #223

Merged
merged 2 commits into from
Sep 22, 2021
Merged

dromedaryCased client properties #223

merged 2 commits into from
Sep 22, 2021

Conversation

Pimm
Copy link
Collaborator

@Pimm Pimm commented Sep 21, 2021

Renamed client properties to dromedary case (customersPayments instead of customers_payments). 🐪 The old snake case names are left as aliases. 🐍

Also renamed the types of these properties from resource to binder (SubscriptionsBinder instead of SubscriptionsResource).

In the PHP client the Payment class extends BaseResource and represents a single payment. This might make it confusing that in this client a PaymentsResource represents the collection of all payments.

docs.mollie.com uses the term API: there is a payments API which represents the collection of all payments. However, we use the term API to represent the entire Mollie API as a whole.

I think the term binder fits, because an accountant could have a binder for customers and a binder for orders.

Client properties (such as customersPayments) are now in dromedaryCase. The previous, snake_case names (such as customers_payments) are left as aliases.
This more closely describes what they are.
@Pimm Pimm merged commit 1a464cf into master Sep 22, 2021
@Pimm Pimm deleted the pimm/v3.6.0 branch September 22, 2021 08:23
Pimm added a commit that referenced this pull request Mar 10, 2023
The snake case client properties (such as customers_payments) were renamed to dromedary case (such as customerPayments) a while ago. See #223 The first version to include this rename is 3.6.0, released on 10 February 2022. This commit removes the snake case aliases which were added for backwards compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants