Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bluebird from moleculer-db-adapter-knex #393

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Remove bluebird from moleculer-db-adapter-knex #393

merged 1 commit into from
Sep 30, 2024

Conversation

Freezystem
Copy link
Contributor

This PR removes the no longer supported bluebird package from knex adapter.

It also replace let statements with const statement when possible.

See deprecation warning.

@Freezystem Freezystem mentioned this pull request Sep 16, 2024
Closed
icebob
icebob approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@icebob icebob merged commit ef97b43 into moleculerjs:master Sep 30, 2024
5 checks passed
@Freezystem Freezystem deleted the fix/remove-bluebird-from-knex-adapter branch October 1, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freezystem @icebob