Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluebird library for promise management shouldn't be used anymore #356

Closed
Freezystem opened this issue May 4, 2023 · 3 comments
Closed

Comments

@Freezystem
Copy link
Contributor

Freezystem commented May 4, 2023

As the bluebird github repo states, bluebird shouldn't be used anymore.
Moreover, the library hasn't got any release since december 2019.

Promises are available in nodeJS since v0.12.0 and the minimum version moleculer supports is nodeJS v8.x.x so this should be safe regarding backward compatibility issues.

We eventually could keep it as devDependency for tests purpose but resort to using native promise in adapters.

I'm willing to make the related PR if it's something that you think should be done.

@icebob
Copy link
Member

icebob commented May 21, 2023

Good idea, a PR would be good, thanks!

@esatterwhite
Copy link

I think in most cases you don't need to use promises directly anymore except in edge cases. An async function returns a promise inherently.

@Freezystem
Copy link
Contributor Author

@icebob icebob closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants