Skip to content

Updates and a new set of Maven and JDK versions to check #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2023

Conversation

dmatej
Copy link
Member

@dmatej dmatej commented May 2, 2023

No description provided.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej force-pushed the newactions branch 3 times, most recently from 299dac6 to c23675a Compare May 2, 2023 19:36
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej marked this pull request as ready for review May 2, 2023 20:05
@dmatej dmatej changed the title New set of Maven and JDK versions to check Updates and a new set of Maven and JDK versions to check May 2, 2023
@dmatej
Copy link
Member Author

dmatej commented May 2, 2023

Don't merge before resolving #12

dmatej added 2 commits May 3, 2023 09:58
- Based on the discussion in PR #12
- The prerequisity should align with the maven-plugin-api dependency, but then
  it duplicates the information.
- If we would use latest api 3.9.1, users would be forced to use Maven 3.9.1+
- If we would use api 3.5.4, we would be stuck in the past and users would be
  forced to use maven 3.5.4
- Now we use api 3.9.1 but we don't limit users to use older or newer Maven
  versions. If they use too old Maven, it is their risk.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej added this to the v2.0.2 milestone May 3, 2023
@dmatej dmatej added the dependencies Pull requests that update a dependency file label May 3, 2023
@dmatej dmatej merged commit 4b51255 into master May 3, 2023
@dmatej dmatej deleted the newactions branch May 3, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant