Require Maven 3.5.4+ #12
Conversation
There was a problem hiding this comment.
I have a question - what is the intention of this change?
I tried to remember and google a bit ... and found just this: https://maven.apache.org/ref/3.9.1/maven-model/maven.html#class_prerequisites
For a plugin project (packaging is maven-plugin), the minimum version of Maven required to use the resulting plugin.
In Maven 2, this was also specifying the minimum version of Maven required to build a project, but this usage is deprecated in Maven 3 and not checked any more: use the Maven Enforcer Plugin's requireMavenVersion rule instead.
|
We are doing cleanup. Setting this property to 3.5.4 will force users to use newer Maven version. |
But then you are going backwards, because the maven-plugin-api here was already set to a newer version. I thought it had some real base like "when users would use Mojohouse plugins with old Maven, they could cause some well defined disaster". |
|
Previous setting to set prerequisites to 3.0 and then depends on newer plugin API was wrong and must be fixed. |
|
Yes I'm aware that this is bigger change and we just do alignment in all our projects - this one is one of 100s. |
You can depend on newer versions. However I would like to see some recommendation from Apache, current change smells (forcing the older api version which will be downloaded even if user would use the latest maven) and the original state smells too (declaring 3.0 but using 3.9.1, but finally that might be ok). Btw I have found much more serious issue, after some time I tried to use the plugin with Maven 3.9.1 - and it failed. It is related to maven versions but has nothing to do with the API ... |
|
Yes, I'm from Apache Maven project :-) |
|
I saw that last release was created by You some time ago. If you prefer we could only sync prerequisites to declared API version. Will this be ok for You? |
Ok, then please add it to FAQ on Maven, also Maven should print some warning. As this plugin is broken now with mvn 3.9.1 I started fixing that and also reconfigured GitHub Actions to be able to detect the issue. However I am still thinking about it, because originally this plugin was to help especially to users using old maven versions and old JDK versions which don't support UTF-8 in property files. Later I have found that even then it is not so simple for all use cases and the plugin is still useful. So basically for me it is easier to go with Maven releases and just validate the backward compatibility by tests. This change does the opposite - defines maven version and then I have to prove that it works with latest maven too. Both ways are limited as these tests are not executed with every maven release. I am bit surprised than Maven 4 still plans to support Java 8? I would expect to move directly to Java 17 (if not 21 - removal of Security Manager and finalizers will cause a lot of pain). https://maven.apache.org/docs/history.html Sorry for my comments, I am trying to fully understand where do we go and why :-) |
|
Btw with my fix it passed even with Maven 3.2.5 ... https://github.com/mojohaus/native2ascii-maven-plugin/actions/runs/4865104187/jobs/8674978200?pr=13 ... and now what ...? |
|
There is yet one possible solution - to remove the |
|
Thx for all informations, I'll left to You to decide what is better for this plugin. Thx. |
Thank you for initiating this and all your time! |
- Based on the discussion in PR #12 - The prerequisity should align with the maven-plugin-api dependency, but then it duplicates the information. - If we would use latest api 3.9.1, users would be forced to use Maven 3.9.1+ - If we would use api 3.5.4, we would be stuck in the past and users would be forced to use maven 3.5.4 - Now we use api 3.9.1 but we don't limit users to use older or newer Maven versions. If they use too old Maven, it is their risk. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Based on the discussion in PR #12 - The prerequisity should align with the maven-plugin-api dependency, but then it duplicates the information. - If we would use latest api 3.9.1, users would be forced to use Maven 3.9.1+ - If we would use api 3.5.4, we would be stuck in the past and users would be forced to use maven 3.5.4 - Now we use api 3.9.1 but we don't limit users to use older or newer Maven versions. If they use too old Maven, it is their risk. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
No description provided.