Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#2801): add fulfil timestamp validation and more error handling #916

Merged
merged 24 commits into from
Aug 15, 2022
Merged

feat(mojaloop/#2801): add fulfil timestamp validation and more error handling #916

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
137ca2b
feat: add fulfil timestamp validation and more error handling
kleyow Aug 2, 2022
12ee66c
chore: space
kleyow Aug 2, 2022
b750475
chore(snapshot): 15.3.0-snapshot.0
kleyow Aug 2, 2022
f8aaf78
chore: change
kleyow Aug 3, 2022
c2d55f1
chore(snapshot): 15.3.0-snapshot.1
kleyow Aug 3, 2022
063e5d2
chore: add error
kleyow Aug 3, 2022
7a5a6fc
chore(snapshot): 15.3.0-snapshot.2
kleyow Aug 3, 2022
e6da540
chore: use enumeration for INVALID bulk transfers
kleyow Aug 4, 2022
6d1feed
Merge remote-tracking branch 'upstream/master' into fix/handle-timeout
kleyow Aug 8, 2022
e978f23
chore: dep
kleyow Aug 8, 2022
6eadabc
chore: add case to handle payer callback
kleyow Aug 10, 2022
b272c69
chore: update
kleyow Aug 10, 2022
f847d0b
chore: changes
kleyow Aug 10, 2022
b2ae2e0
chore: revert
kleyow Aug 10, 2022
d0694a9
chore: diff
kleyow Aug 11, 2022
49ec0bc
Merge remote-tracking branch 'upstream/master' into fix/handle-timeout
kleyow Aug 11, 2022
4ecd613
chore: todo
kleyow Aug 11, 2022
7dcac96
chore: changes
kleyow Aug 12, 2022
4087a8c
chore: update
kleyow Aug 12, 2022
5abdd5a
chore: dep
kleyow Aug 15, 2022
1ab5e0f
chore: address comments and dep
kleyow Aug 15, 2022
5563ff0
chore: lock
kleyow Aug 15, 2022
8108b24
chore: validator tests
kleyow Aug 15, 2022
2c0ead0
chore: enum
kleyow Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add error
  • Loading branch information
@kleyow
kleyow committed Aug 3, 2022
commit 063e5d232c20809037cd81c73db0d036a6bcfbcd
3 changes: 2 additions & 1 deletion src/handlers/bulk/fulfil/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,9 @@ const bulkFulfil = async (error, messages) => {
*/
const state = await BulkTransferService.bulkFulfil(payload, reasons.toString(), false)
const bulkTransfers = await BulkTransferService.getBulkTransferById(payload.bulkTransferId)
const fspiopError = ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.VALIDATION_ERROR, 'Bulk fulfil failed validation')
for (const individualTransferFulfil of bulkTransfers.payeeBulkTransfer.individualTransferResults) {
individualTransferFulfil.errorInformation = payload.errorInformation
individualTransferFulfil.errorInformation = fspiopError.toApiErrorObject().errorInformation
await sendIndividualTransfer(message, messageId, kafkaTopic, headers, payload, state, params, individualTransferFulfil, histTimerEnd)
}
} catch (err) {
Expand Down