feat(mojaloop/#2801): add fulfil timestamp validation and more error handling #916
Conversation
kleyow
requested review from
mdebarros,
elnyry-sam-k and
vijayg10
as code owners
| @@ -18,6 +18,7 @@ | |||
| "CREATE_RETRY_INTERVAL_MILLIS": 200, | |||
| "DEBUG": false | |||
| }, | |||
| "MAX_FULFIL_TIMEOUT_DURATION_SECONDS": 300, | |||
There was a problem hiding this comment.
I believe this is a breaking change right?
I.e. What is the impact if we do not provide the MAX_FULFIL_TIMEOUT_DURATION_SECONDS config either via default.json or env file?
There was a problem hiding this comment.
There is a default timeout that it will default to https://github.com/mojaloop/central-ledger/pull/916/files#diff-b69d6bde1ed95b38264df8b79c66099602625f0eb541d4e98001baed223096d7R213 so it should work without specifying it in the config or env.
kleyow
changed the title
| return { isValid, reasons } | ||
| } | ||
|
|
||
| const validateCompletedTimestamp = (payload) => { | ||
| const maxLag = (Config.MAX_FULFIL_TIMEOUT_DURATION_SECONDS || defaultLagSeconds) * 1000 |
There was a problem hiding this comment.
Would it not be better to have the default values set in the config.js instead of here?
src/lib/config.js
Outdated
| @@ -3,6 +3,7 @@ const RC = require('rc')('CLEDG', require('../../config/default.json')) | |||
| module.exports = { | |||
| HOSTNAME: RC.HOSTNAME.replace(/\/$/, ''), | |||
| PORT: RC.PORT, | |||
| MAX_FULFIL_TIMEOUT_DURATION_SECONDS: RC.MAX_FULFIL_TIMEOUT_DURATION_SECONDS, | |||
There was a problem hiding this comment.
I.e. I feel that it would be better to have the default value set here.
There was a problem hiding this comment.
Yes. It's better. done.
feat(mojaloop/#2801): add fulfil timestamp validation and more error handling - mojaloop/project#2801
bulk-api-adapter