Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim context setting keys on creation #16500

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Trim context setting keys on creation #16500

merged 1 commit into from
Mar 25, 2024

Conversation

Jako
Copy link
Collaborator

@Jako Jako commented Dec 1, 2023

What does it do?

3.x port of #16498

@Ibochkarev Ibochkarev added the pr/review-needed Pull request requires review and testing. label Jan 31, 2024
@Mark-H Mark-H added this to the v3.0.5 milestone Feb 10, 2024
@smg6511 smg6511 added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Mar 21, 2024
theboxer
theboxer approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@opengeek opengeek changed the title [MODX3] Trim the context setting key during creating a new context setting Trim context setting keys on creation Mar 25, 2024
@opengeek opengeek merged commit 4f8a835 into modxcms:3.x Mar 25, 2024
5 checks passed
opengeek pushed a commit that referenced this pull request Mar 25, 2024
@Jako @opengeek
Trim context setting keys on creation (#16500)
d433e80 
## What does it do?
3.x port of #16498
@Jako Jako deleted the patch-2 branch March 25, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ibochkarev Ibochkarev Ibochkarev approved these changes

@theboxer theboxer theboxer approved these changes

@smg6511 smg6511 smg6511 approved these changes

@opengeek opengeek Awaiting requested review from opengeek opengeek is a code owner

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

Assignees
No one assigned
Labels
pr/ready-for-merging Pull request reviewed and tested and ready for merging.
Projects
None yet
Milestone
v3.0.5
Development

Successfully merging this pull request may close these issues.
6 participants
@Jako @smg6511 @theboxer @Ibochkarev @opengeek @Mark-H