Trim context setting keys on creation #16498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2023
rthrash
added
bug
smg6511
approved these changes
Mar 21, 2024
Ibochkarev
approved these changes
Mar 21, 2024
smg6511
added
pr/ready-for-merging
opengeek
changed the title
opengeek
pushed a commit
that referenced
this pull request
Mar 25, 2024
## What does it do? 3.x port of #16498
opengeek
pushed a commit
that referenced
this pull request
Mar 25, 2024
## What does it do? 3.x port of #16498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Trim the context setting key.
Why is it needed?
System and user settings keys are trimmed, but not the context setting key.
Related issue
The issue occurred in CrossContextsSettings. It uses the core context settings processor:
https://community.modx.com/t/langrouter-issues/7262