Skip to content

Conversation

@ScriptedAlchemy
Copy link
Member

Description

Fix types issue on beforePreloadRemote

Related Issue

#2505

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: d04b42d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@module-federation/runtime Patch
@module-federation/devtools Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/runtime-tools Patch
@module-federation/webpack-bundler-runtime Patch
node-dynamic-remote-new-version Patch
node-dynamic-remote Patch
@module-federation/enhanced Patch
@module-federation/rspack Patch
3008-runtime-remote Patch
@module-federation/modernjs Patch
@module-federation/sdk Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/utilities Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review May 20, 2024 20:59
@ScriptedAlchemy ScriptedAlchemy requested a review from 2heal1 May 20, 2024 20:59
@netlify
Copy link

netlify bot commented May 20, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit d04b42d
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/664c1e41d22d550008460173
😎 Deploy Preview https://deploy-preview-2515--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RussellCanfield
Copy link
Contributor

I think the other preload hooks may have the same issue, I need to test it

@ScriptedAlchemy
Copy link
Member Author

@RussellCanfield can you confirm if others are busted, ill patch them in a follow up pr.

@ScriptedAlchemy ScriptedAlchemy merged commit 103cd07 into main May 21, 2024
@ScriptedAlchemy ScriptedAlchemy deleted the fix/before-preload-types branch May 21, 2024 09:17
@2heal1 2heal1 mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants