Runtime Plugin - beforePreloadRemote

[RussellCanfield]

Describe the bug

It appears that types are not working correctly for beforePreloadRemote in a runtime plugin. When implementing the hook in a plugin like so:

@module-federation/enhanced v0.1.13

import type { FederationRuntimePlugin } from '@module-federation/enhanced/runtime';

const runtimePlugin: () => FederationRuntimePlugin = function () {
  return {
    name: 'my-runtime-plugin',
    async beforePreloadRemote(args) {
      //args here is of type any
      console.log(args);
      return args;
    },
  };
};
export default runtimePlugin;

It appears that "args" being passed into "beforePreloadRemote" is any. The object names are also not correct, intelisense picks them up as "preloadOps" but it is actually "preloadOptions".

Reproduction

https://github.com/RussellCanfield/nx-rspack-microfrontend-demo/blob/47616c706e7cdd996cf55a45d8655679d977033a/apps/mfe-monorepo/src/dynamic-loader-plugin.ts#L7

Used Package Manager

npm

System Info

@module-federation/enhanced v0.1.13
VSCode
Typescript 5.4.4

Validations

• Read the docs.
• Read the common issues list.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Module federation issue and not a framework-specific issue.
• The provided reproduction is a minimal reproducible example of the bug.

[ScriptedAlchemy]

@RussellCanfield do you know why its returning any? Looking at the hooks it seems to have types etc

[RussellCanfield]

@RussellCanfield do you know why its returning any? Looking at the hooks it seems to have types etc

Nevermind your fix isn't published yet :), your change appears to be working. "afterPreloadRemote" can receive a similar fix. I think just wrapping the object in AsyncHook in an array seems to fix it.

For some reason commitlint is failing for me or I'd commit the change, but identical fix to what you did

[github-actions]

Stale issue message