This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Add InSpec support for source repositories #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libraries/google_bigquery_dataset.rb
Outdated
|
|
||
| private | ||
|
|
||
| def _base |
There was a problem hiding this comment.
From what I've seen, Ruby doesn't seem to do the _method notation to say something is private. They either put the method under the private section or (less so) write private def method. Python definitely does the _method thing for private methods and I feel like that's where it's most famously done.
Some people do place an underscore and honestly, I don't really care either way. Your call.
There was a problem hiding this comment.
Yeah, I was searching around for some kind of Ruby prefix for indicating that it is private. Seems like some people use _ but it's not standard. I needed to prefix these methods so they won't conflict with resource properties, or else rename them to something more specific.
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
force-pushed
the
codegen-pr-1411
branch
from
3f2c851 to
fb2b900
Compare
slevenick
pushed a commit
that referenced
this pull request
Feb 25, 2019
Update google_organization(s) controls only_if condition to include o…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @slevenick