Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InSpec support for source repositories #1411

Merged
merged 6 commits into from
Feb 20, 2019
Merged

Add InSpec support for source repositories #1411

merged 6 commits into from
Feb 20, 2019

Conversation

slevenick
Copy link
Contributor

Add InSpec support for source repositories

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 5dc3b98.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-provider-google.
No diff detected in Ansible.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/inspec-gcp#112

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 97da3c3.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
Ansible already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 881f8f7.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
Ansible already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

rambleraptor
rambleraptor approved these changes Feb 19, 2019
View reviewed changes
templates/inspec/tests/integration/configuration/mm-attributes.yml

repository:
name: inspec-gcp-repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think repositories are pretty new in Terraform. Do we have a version in-mind for users when they run Terraform for testing?

(I know we're probably the only people running Terraform for testing, but it would be a good idea to state somewhere what version of Terraform users should use to run all of this)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I should add this to the readme in the inspec-gcp repo. They were already using Terraform for testing, but this addition may require people to upgrade. There is no terraform version stated currently

@modular-magician modular-magician merged commit abf1d64 into master Feb 20, 2019
@slevenick slevenick deleted the inspec-source-repo branch April 15, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambleraptor rambleraptor rambleraptor approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated inspec no-op
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slevenick @modular-magician @rambleraptor @googlebot