Skip to content

Conversation

@Prospector
Copy link
Member

@Prospector Prospector commented Sep 29, 2025

Fixes #4423

@IMB11 IMB11 enabled auto-merge September 29, 2025 02:20
@IMB11 IMB11 requested a review from Copilot September 29, 2025 02:20
@IMB11 IMB11 added this pull request to the merge queue Sep 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the withdraw button appeared disabled due to incorrect boolean attribute handling in Vue.js. The change ensures that when the withdraw button should be enabled, the disabled attribute is completely removed from the DOM element rather than being set to a string value.

Key Changes

  • Updated the :disabled attribute binding to use proper boolean logic that removes the attribute when the button should be enabled

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"
:class="{ 'disabled-link': userBalance.available < minWithdraw || blockedByTax }"
:disabled="userBalance.available < minWithdraw || blockedByTax ? 'true' : 'false'"
:disabled="!!(userBalance.available < minWithdraw || blockedByTax) || null"
Copy link

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expression !!(condition) || null is unnecessarily complex. In Vue.js, you can simply use the boolean condition directly: :disabled="userBalance.available < minWithdraw || blockedByTax". Vue will automatically handle the attribute presence/absence based on the boolean value.

Suggested change
:disabled="!!(userBalance.available < minWithdraw || blockedByTax) || null"
:disabled="userBalance.available < minWithdraw || blockedByTax"

Copilot uses AI. Check for mistakes.
Merged via the queue into main with commit d5f756f Sep 29, 2025
2 checks passed
@Prospector Prospector deleted the prospector/fix-withdraw-button branch September 29, 2025 18:07
fetchfern pushed a commit that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Withdraw button looks disabled, but is clickable

2 participants