REFACTOR-#2035: move getitem_array to the backend #2036

ienkovich · 2020-09-07T14:18:11Z

What do these changes do?

This patch moves getitem_array implementation from API level to the backend. This allows OmniSci backend to have its own implementation with a lazy bool indexer support.

commit message follows format outlined here
passes flake8 modin
passes black --check modin
signed commit with git commit -s
Resolves [REFACTOR] Avoid API level index access in getitem for bool indexer #2035
tests passing

modin-bot · 2020-09-07T14:33:44Z

TeamCity Python test results bot

Tests PASSed

Tests Logs

============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
collected 113 items

modin/pandas/test/test_io.py .................sX..........s............. [ 38%]
........s...........................s..s.X.....s..................ss..   [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml


=========== 103 passed, 8 skipped, 2 xpassed, 127 warnings in 34.60s ===========
Closing remaining open files:test_write_modin.hdf...donetest_write_pandas.hdf...done
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I / gw8 I / gw9 I / gw10 I / gw11 I / gw12 I / gw13 I / gw14 I / gw15 I / gw16 I / gw17 I / gw18 I / gw19 I / gw20 I / gw21 I / gw22 I / gw23 I / gw24 I / gw25 I / gw26 I / gw27 I / gw28 I / gw29 I / gw30 I / gw31 I / gw32 I / gw33 I / gw34 I / gw35 I / gw36 I / gw37 I / gw38 I / gw39 I / gw40 I / gw41 I / gw42 I / gw43 I / gw44 I / gw45 I / gw46 I / gw47 I
gw0 [5399] / gw1 [5399] / gw2 [5399] / gw3 [5399] / gw4 [5399] / gw5 [5399] / gw6 [5399] / gw7 [5399] / gw8 [5399] / gw9 [5399] / gw10 [5399] / gw11 [5399] / gw12 [5399] / gw13 [5399] / gw14 [5399] / gw15 [5399] / gw16 [5399] / gw17 [5399] / gw18 [5399] / gw19 [5399] / gw20 [5399] / gw21 [5399] / gw22 [5399] / gw23 [5399] / gw24 [5399] / gw25 [5399] / gw26 [5399] / gw27 [5399] / gw28 [5399] / gw29 [5399] / gw30 [5399] / gw31 [5399] / gw32 [5399] / gw33 [5399] / gw34 [5399] / gw35 [5399] / gw36 [5399] / gw37 [5399] / gw38 [5399] / gw39 [5399] / gw40 [5399] / gw41 [5399] / gw42 [5399] / gw43 [5399] / gw44 [5399] / gw45 [5399] / gw46 [5399] / gw47 [5399]

........................................................................ [  1%]
........................................................................ [  2%]
........................................................................ [  3%]
........................................................................ [  5%]
........................................................................ [  6%]
........................................................................ [  7%]
.....................................s.................................. [  9%]
.................................................X.....s.............x.. [ 10%]
......................x.............xx.xx.....xx....x................... [ 12%]
............x.....................................x..................x.. [ 13%]
x.......x......x.............x....x.........x..x........................ [ 14%]
..............xx........x..........................................x.... [ 16%]
....x....x........x...............X..................x..x...x...Xx...... [ 17%]
...x......................X..X................X....X..............X....x [ 18%]
...x..xX.X....X.......X..x....x...XX....x.X.........XxX.Xx..........x.x. [ 20%]
x.X.X..........x.x....x......xX.....xX.x.....X.....x.......XX...x....X.. [ 21%]
...x....XX............x...X....x......X.............X.....XXx.X.x......X [ 22%]
..........s.............Xx...............X......................X....... [ 24%]
.X.........XX........X....................X................X............ [ 25%]
..X..........X...X..............X................................X...... [ 26%]
....................XX..........X.........X............................X [ 28%]
...............x...x.................................................... [ 29%]
..........x.................x.......................x.....X............. [ 30%]
......x......................x................s......x.................. [ 32%]
.............................x.........................x................ [ 33%]
............................x.....x....X................................ [ 34%]
........X....x....................x..................................... [ 36%]
..x........................x..............x............................. [ 37%]
X..x....................X........................................x...... [ 38%]
............................................x..........X................. [ 40%]
.................X.....................................X................ [ 41%]
...........X.............................................X.............. [ 42%]
................x..........X....................xx......X............... [ 44%]
...........................................X....x....................... [ 45%]
....................X....xx.....x....................................... [ 46%]
..........................................x...sssssssss.x............... [ 48%]
.................xx..........................x.......................... [ 49%]
.................x...................................................... [ 50%]
....xx......................sssssssssss.s...................x........... [ 52%]
............................x...........x............................... [ 53%]
..................................X.......x............................. [ 54%]
.....x.............s....X............................................... [ 56%]
x..X...............................................x...................s [ 57%]
ss...............x......X......................................X........ [ 58%]
.............................s..........X....x........x.............X... [ 60%]
...........................X......ss..Xx............................X.... [ 61%]
.....................................ssss.sssssss...s..............XX... [ 62%]
...................X.........................X..................X....... [ 64%]
....X...............x...............................x................... [ 65%]
.....x..x.........................x................x.................... [ 66%]
......x................s..X..............X....x..X.....x.......xX......x [ 68%]
........X.........x....X..x...x....Xx..xx....Xx....x.....X..xx....x..... [ 69%]
x.x....x................................................................ [ 70%]
..........................................................X............. [ 72%]
......................................................................... [ 73%]
.................................................................X...X.. [ 74%]
................................................................s....... [ 76%]
............s.....................s.......s.....s.....s...ss......s..... [ 77%]
s....s....xs...s....s......x..s....s..........x.....x.....s..x.....s...x [ 78%]
.........x.x....x..........x..x......s...............................s.. [ 80%]
.....X......X........X.X.s..X......XX....X.X..........X....s..XX...X...X [ 81%]
X......XX........XX.x.X...s..X.X.......X..X..X.s..........X..X.......... [ 82%]
............X......X...........X.......X....................x........X.. [ 84%]
...........x.............................................X....X......... [ 85%]
.......X............X.....................X....x......X................. [ 86%]
.....................X..X.......................x...X.................X. [ 88%]
......................xX...................X.x..........X...x..x.xxx...x [ 89%]
..x.........X....x.X.........X......X....X.....X........................ [ 90%]
..x.............xx...........x.......................................... [ 92%]
x.........................X............................................. [ 93%]
.x.xx..x....x.......x...........xx.X...X........xX....X.x...........x... [ 94%]
..x..........xx...........x............................................. [ 96%]
................................x....................................... [ 97%]
...................x.................................................... [ 98%]
................................................x...................     [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml

== 5002 passed, 69 skipped, 176 xfailed, 152 xpassed, 9507 warnings in 48.95s ==
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
collected 113 items

modin/pandas/test/test_io.py .................sX..........s............. [ 38%]
........s...........................s..s.X.....s..................ss..   [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml


=========== 103 passed, 8 skipped, 2 xpassed, 127 warnings in 34.60s ===========
Closing remaining open files:test_write_modin.hdf...donetest_write_pandas.hdf...done
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I / gw8 I / gw9 I / gw10 I / gw11 I / gw12 I / gw13 I / gw14 I / gw15 I / gw16 I / gw17 I / gw18 I / gw19 I / gw20 I / gw21 I / gw22 I / gw23 I / gw24 I / gw25 I / gw26 I / gw27 I / gw28 I / gw29 I / gw30 I / gw31 I / gw32 I / gw33 I / gw34 I / gw35 I / gw36 I / gw37 I / gw38 I / gw39 I / gw40 I / gw41 I / gw42 I / gw43 I / gw44 I / gw45 I / gw46 I / gw47 I
gw0 [5399] / gw1 [5399] / gw2 [5399] / gw3 [5399] / gw4 [5399] / gw5 [5399] / gw6 [5399] / gw7 [5399] / gw8 [5399] / gw9 [5399] / gw10 [5399] / gw11 [5399] / gw12 [5399] / gw13 [5399] / gw14 [5399] / gw15 [5399] / gw16 [5399] / gw17 [5399] / gw18 [5399] / gw19 [5399] / gw20 [5399] / gw21 [5399] / gw22 [5399] / gw23 [5399] / gw24 [5399] / gw25 [5399] / gw26 [5399] / gw27 [5399] / gw28 [5399] / gw29 [5399] / gw30 [5399] / gw31 [5399] / gw32 [5399] / gw33 [5399] / gw34 [5399] / gw35 [5399] / gw36 [5399] / gw37 [5399] / gw38 [5399] / gw39 [5399] / gw40 [5399] / gw41 [5399] / gw42 [5399] / gw43 [5399] / gw44 [5399] / gw45 [5399] / gw46 [5399] / gw47 [5399]

........................................................................ [  1%]
........................................................................ [  2%]
........................................................................ [  3%]
........................................................................ [  5%]
........................................................................ [  6%]
........................................................................ [  7%]
.....................................s.................................. [  9%]
.................................................X.....s.............x.. [ 10%]
......................x.............xx.xx.....xx....x................... [ 12%]
............x.....................................x..................x.. [ 13%]
x.......x......x.............x....x.........x..x........................ [ 14%]
..............xx........x..........................................x.... [ 16%]
....x....x........x...............X..................x..x...x...Xx...... [ 17%]
...x......................X..X................X....X..............X....x [ 18%]
...x..xX.X....X.......X..x....x...XX....x.X.........XxX.Xx..........x.x. [ 20%]
x.X.X..........x.x....x......xX.....xX.x.....X.....x.......XX...x....X.. [ 21%]
...x....XX............x...X....x......X.............X.....XXx.X.x......X [ 22%]
..........s.............Xx...............X......................X....... [ 24%]
.X.........XX........X....................X................X............ [ 25%]
..X..........X...X..............X................................X...... [ 26%]
....................XX..........X.........X............................X [ 28%]
...............x...x.................................................... [ 29%]
..........x.................x.......................x.....X............. [ 30%]
......x......................x................s......x.................. [ 32%]
.............................x.........................x................ [ 33%]
............................x.....x....X................................ [ 34%]
........X....x....................x..................................... [ 36%]
..x........................x..............x............................. [ 37%]
X..x....................X........................................x...... [ 38%]
............................................x..........X................. [ 40%]
.................X.....................................X................ [ 41%]
...........X.............................................X.............. [ 42%]
................x..........X....................xx......X............... [ 44%]
...........................................X....x....................... [ 45%]
....................X....xx.....x....................................... [ 46%]
..........................................x...sssssssss.x............... [ 48%]
.................xx..........................x.......................... [ 49%]
.................x...................................................... [ 50%]
....xx......................sssssssssss.s...................x........... [ 52%]
............................x...........x............................... [ 53%]
..................................X.......x............................. [ 54%]
.....x.............s....X............................................... [ 56%]
x..X...............................................x...................s [ 57%]
ss...............x......X......................................X........ [ 58%]
.............................s..........X....x........x.............X... [ 60%]
...........................X......ss..Xx............................X.... [ 61%]
.....................................ssss.sssssss...s..............XX... [ 62%]
...................X.........................X..................X....... [ 64%]
....X...............x...............................x................... [ 65%]
.....x..x.........................x................x.................... [ 66%]
......x................s..X..............X....x..X.....x.......xX......x [ 68%]
........X.........x....X..x...x....Xx..xx....Xx....x.....X..xx....x..... [ 69%]
x.x....x................................................................ [ 70%]
..........................................................X............. [ 72%]
......................................................................... [ 73%]
.................................................................X...X.. [ 74%]
................................................................s....... [ 76%]
............s.....................s.......s.....s.....s...ss......s..... [ 77%]
s....s....xs...s....s......x..s....s..........x.....x.....s..x.....s...x [ 78%]
.........x.x....x..........x..x......s...............................s.. [ 80%]
.....X......X........X.X.s..X......XX....X.X..........X....s..XX...X...X [ 81%]
X......XX........XX.x.X...s..X.X.......X..X..X.s..........X..X.......... [ 82%]
............X......X...........X.......X....................x........X.. [ 84%]
...........x.............................................X....X......... [ 85%]
.......X............X.....................X....x......X................. [ 86%]
.....................X..X.......................x...X.................X. [ 88%]
......................xX...................X.x..........X...x..x.xxx...x [ 89%]
..x.........X....x.X.........X......X....X.....X........................ [ 90%]
..x.............xx...........x.......................................... [ 92%]
x.........................X............................................. [ 93%]
.x.xx..x....x.......x...........xx.X...X........xX....X.x...........x... [ 94%]
..x..........xx...........x............................................. [ 96%]
................................x....................................... [ 97%]
...................x.................................................... [ 98%]
................................................x...................     [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml

== 5002 passed, 69 skipped, 176 xfailed, 152 xpassed, 9507 warnings in 48.95s ==

codecov · 2020-09-07T14:34:12Z

Codecov Report

Merging #2036 into master will decrease coverage by 0.09%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #2036      +/-   ##
==========================================
- Coverage   82.11%   82.02%   -0.10%     
==========================================
  Files          80       80              
  Lines        9611     9617       +6     
==========================================
- Hits         7892     7888       -4     
- Misses       1719     1729      +10

Impacted Files	Coverage Δ
modin/pandas/dataframe.py	`90.49% <80.00%> (+0.06%)`	⬆️
modin/backends/pandas/query_compiler.py	`96.34% <84.21%> (-0.24%)`	⬇️
modin/backends/base/query_compiler.py	`100.00% <100.00%> (ø)`
modin/backends/pandas/parsers.py	`45.41% <0.00%> (-4.59%)`	⬇️
modin/experimental/cloud/meta_magic.py	`85.45% <0.00%> (+1.81%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ca3f34...61072c3. Read the comment docs.

modin-bot · 2020-09-07T14:41:31Z

TeamCity Dask test results bot

Tests PASSed

Tests Logs

============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
collected 113 items

modin/pandas/test/test_io.py .................sx..........s............. [ 38%]
....................................s..s.X.....s..................ss..   [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml


= 104 passed, 7 skipped, 1 xfailed, 1 xpassed, 107 warnings in 72.98s (0:01:12) =
Closing remaining open files:test_write_modin.hdf...donetest_write_pandas.hdf...done
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I / gw8 I / gw9 I / gw10 I / gw11 I / gw12 I / gw13 I / gw14 I / gw15 I / gw16 I / gw17 I / gw18 I / gw19 I / gw20 I / gw21 I / gw22 I / gw23 I / gw24 I / gw25 I / gw26 I / gw27 I / gw28 I / gw29 I / gw30 I / gw31 I / gw32 I / gw33 I / gw34 I / gw35 I / gw36 I / gw37 I / gw38 I / gw39 I / gw40 I / gw41 I / gw42 I / gw43 I / gw44 I / gw45 I / gw46 I / gw47 I
gw0 [5399] / gw1 [5399] / gw2 [5399] / gw3 [5399] / gw4 [5399] / gw5 [5399] / gw6 [5399] / gw7 [5399] / gw8 [5399] / gw9 [5399] / gw10 [5399] / gw11 [5399] / gw12 [5399] / gw13 [5399] / gw14 [5399] / gw15 [5399] / gw16 [5399] / gw17 [5399] / gw18 [5399] / gw19 [5399] / gw20 [5399] / gw21 [5399] / gw22 [5399] / gw23 [5399] / gw24 [5399] / gw25 [5399] / gw26 [5399] / gw27 [5399] / gw28 [5399] / gw29 [5399] / gw30 [5399] / gw31 [5399] / gw32 [5399] / gw33 [5399] / gw34 [5399] / gw35 [5399] / gw36 [5399] / gw37 [5399] / gw38 [5399] / gw39 [5399] / gw40 [5399] / gw41 [5399] / gw42 [5399] / gw43 [5399] / gw44 [5399] / gw45 [5399] / gw46 [5399] / gw47 [5399]

........................................................................ [  1%]
........................................................................ [  2%]
........................................................................ [  3%]
........................................................................ [  5%]
........................................................................ [  6%]
........................................................................ [  8%]
......................x......s.......................................... [  9%]
...........x.....................x.......x......................x....... [ 10%]
......x....................x....................................X....... [ 11%]
..s....x.x............x..........................................x...... [ 13%]
x.....x......x..x...x......x.........x........x...x...................... [ 14%]
...............X..........................................x............x [ 16%]
.........x.....................x......x...................x............. [ 17%]
...................................x.................................... [ 18%]
............x.................x................................X........ [ 20%]
..........x.....................x....................................... [ 21%]
.....x....s.............................................................. [ 22%]
............X.....X..................................................... [ 24%]
.........X....................X..............X.............xXX...x....X. [ 25%]
........................................x........xx..................... [ 26%]
...................................xxx.......x....x..................... [ 28%]
................x.....x....xx................X..X...........X........... [ 29%]
..........x...x.......x...........x.................xX.................X [ 30%]
.........X..x...x.............X.................X.........X.............. [ 32%]
.........................x.........x....................x............... [ 33%]
...............x...............x.........XX........X..X.......X.......x. [ 34%]
...X..X...........x........XX.......X.............X.......X....X...X.... [ 36%]
....X.........x.......x.....X...............................x...x........ [ 37%]
.....x...x......x......X..........X.......xx........x................... [ 38%]
...x..x.......x.X...............x...x....................x..x........... [ 40%]
...................x.............xx...................x................. [ 41%]
....X..xx....xxX...x..Xx......X.X....X....X.X..X....XX........X......... [ 42%]
X....X.........XX.X.X.......X.sssss...sss.s.ss..ss.s.s.s..s.........x... [ 44%]
...............s..ss.ss.....x..X..............X............X..x......X.. [ 45%]
...X....X..................x..........xx...........x..............x.....x [ 46%]
.................x.x.....X....s.s..ss.ss.ss.sXss.ss.s....x....X.......... [ 48%]
..............x..............................x.......................... [ 49%]
..x.......X............X.X....s....X....................................... [ 50%]
........................................................................ [ 52%]
........X........X...X......X..X........................................ [ 53%]
........................................................................ [ 54%]
.................................................x...................... [ 56%]
........................................................................ [ 57%]
......x..........................x...............X......X......x.....x.. [ 58%]
....x................x................x.............x.............X...x. [ 60%]
............x.....s...x....X...XX...XX....X.............................. [ 61%]
.....................................................................x.. [ 62%]
.......x................................................................ [ 64%]
........................................................................ [ 65%]
....x.............................................................X..... [ 66%]
........X............................................................... [ 68%]
........................................................................ [ 69%]
............................ss.........................................s [ 70%]
.....................X.................................................. [ 72%]
..........s.............................x............................... [ 73%]
.........................................................X.............. [ 74%]
........................................s..............s................ [ 76%]
s....................................ssX............s........s..s....... [ 77%]
......x....s.................s.x..s.s..s..x...........xx..x....s......... [ 78%]
s...x.......sxx.x......s.x..s....X..XX.s.xX...XX........s....x..xx...... [ 80%]
...s..s.x......s......X...x....X.....X..X.....X.........sX....x..XX..... [ 81%]
.X....XX.......X......X....X..X...X.XX....X..X....xX....X.......XXXX.... [ 82%]
.....X..XX...X.X.x..............X.x.....x.X......X.....X............X..X [ 84%]
..X.x.X...............X.........x....................X.................. [ 85%]
..............................................................x...X..... [ 86%]
...X..........................X....................x.....X............... [ 88%]
.....................................X.................................. [ 89%]
.....x.........xxxxx......xxXx......x......X.x.X..X.....X................ [ 90%]
...X...........X.........x......x...............X....................... [ 92%]
.............................x.......................................... [ 93%]
.................................................x...x.xxx....x.....x... [ 94%]
...x......x...........xx...........x.........x....................xx.... [ 96%]
.x..............................................x.........X..X.......x.. [ 97%]
........................................................................ [ 98%]
..........................................................               [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml

= 5002 passed, 69 skipped, 176 xfailed, 152 xpassed, 9509 warnings in 114.40s (0:01:54) =
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
collected 113 items

modin/pandas/test/test_io.py .................sx..........s............. [ 38%]
....................................s..s.X.....s..................ss..   [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml


= 104 passed, 7 skipped, 1 xfailed, 1 xpassed, 107 warnings in 72.98s (0:01:12) =
Closing remaining open files:test_write_modin.hdf...donetest_write_pandas.hdf...done
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I / gw8 I / gw9 I / gw10 I / gw11 I / gw12 I / gw13 I / gw14 I / gw15 I / gw16 I / gw17 I / gw18 I / gw19 I / gw20 I / gw21 I / gw22 I / gw23 I / gw24 I / gw25 I / gw26 I / gw27 I / gw28 I / gw29 I / gw30 I / gw31 I / gw32 I / gw33 I / gw34 I / gw35 I / gw36 I / gw37 I / gw38 I / gw39 I / gw40 I / gw41 I / gw42 I / gw43 I / gw44 I / gw45 I / gw46 I / gw47 I
gw0 [5399] / gw1 [5399] / gw2 [5399] / gw3 [5399] / gw4 [5399] / gw5 [5399] / gw6 [5399] / gw7 [5399] / gw8 [5399] / gw9 [5399] / gw10 [5399] / gw11 [5399] / gw12 [5399] / gw13 [5399] / gw14 [5399] / gw15 [5399] / gw16 [5399] / gw17 [5399] / gw18 [5399] / gw19 [5399] / gw20 [5399] / gw21 [5399] / gw22 [5399] / gw23 [5399] / gw24 [5399] / gw25 [5399] / gw26 [5399] / gw27 [5399] / gw28 [5399] / gw29 [5399] / gw30 [5399] / gw31 [5399] / gw32 [5399] / gw33 [5399] / gw34 [5399] / gw35 [5399] / gw36 [5399] / gw37 [5399] / gw38 [5399] / gw39 [5399] / gw40 [5399] / gw41 [5399] / gw42 [5399] / gw43 [5399] / gw44 [5399] / gw45 [5399] / gw46 [5399] / gw47 [5399]

........................................................................ [  1%]
........................................................................ [  2%]
........................................................................ [  3%]
........................................................................ [  5%]
........................................................................ [  6%]
........................................................................ [  8%]
......................x......s.......................................... [  9%]
...........x.....................x.......x......................x....... [ 10%]
......x....................x....................................X....... [ 11%]
..s....x.x............x..........................................x...... [ 13%]
x.....x......x..x...x......x.........x........x...x...................... [ 14%]
...............X..........................................x............x [ 16%]
.........x.....................x......x...................x............. [ 17%]
...................................x.................................... [ 18%]
............x.................x................................X........ [ 20%]
..........x.....................x....................................... [ 21%]
.....x....s.............................................................. [ 22%]
............X.....X..................................................... [ 24%]
.........X....................X..............X.............xXX...x....X. [ 25%]
........................................x........xx..................... [ 26%]
...................................xxx.......x....x..................... [ 28%]
................x.....x....xx................X..X...........X........... [ 29%]
..........x...x.......x...........x.................xX.................X [ 30%]
.........X..x...x.............X.................X.........X.............. [ 32%]
.........................x.........x....................x............... [ 33%]
...............x...............x.........XX........X..X.......X.......x. [ 34%]
...X..X...........x........XX.......X.............X.......X....X...X.... [ 36%]
....X.........x.......x.....X...............................x...x........ [ 37%]
.....x...x......x......X..........X.......xx........x................... [ 38%]
...x..x.......x.X...............x...x....................x..x........... [ 40%]
...................x.............xx...................x................. [ 41%]
....X..xx....xxX...x..Xx......X.X....X....X.X..X....XX........X......... [ 42%]
X....X.........XX.X.X.......X.sssss...sss.s.ss..ss.s.s.s..s.........x... [ 44%]
...............s..ss.ss.....x..X..............X............X..x......X.. [ 45%]
...X....X..................x..........xx...........x..............x.....x [ 46%]
.................x.x.....X....s.s..ss.ss.ss.sXss.ss.s....x....X.......... [ 48%]
..............x..............................x.......................... [ 49%]
..x.......X............X.X....s....X....................................... [ 50%]
........................................................................ [ 52%]
........X........X...X......X..X........................................ [ 53%]
........................................................................ [ 54%]
.................................................x...................... [ 56%]
........................................................................ [ 57%]
......x..........................x...............X......X......x.....x.. [ 58%]
....x................x................x.............x.............X...x. [ 60%]
............x.....s...x....X...XX...XX....X.............................. [ 61%]
.....................................................................x.. [ 62%]
.......x................................................................ [ 64%]
........................................................................ [ 65%]
....x.............................................................X..... [ 66%]
........X............................................................... [ 68%]
........................................................................ [ 69%]
............................ss.........................................s [ 70%]
.....................X.................................................. [ 72%]
..........s.............................x............................... [ 73%]
.........................................................X.............. [ 74%]
........................................s..............s................ [ 76%]
s....................................ssX............s........s..s....... [ 77%]
......x....s.................s.x..s.s..s..x...........xx..x....s......... [ 78%]
s...x.......sxx.x......s.x..s....X..XX.s.xX...XX........s....x..xx...... [ 80%]
...s..s.x......s......X...x....X.....X..X.....X.........sX....x..XX..... [ 81%]
.X....XX.......X......X....X..X...X.XX....X..X....xX....X.......XXXX.... [ 82%]
.....X..XX...X.X.x..............X.x.....x.X......X.....X............X..X [ 84%]
..X.x.X...............X.........x....................X.................. [ 85%]
..............................................................x...X..... [ 86%]
...X..........................X....................x.....X............... [ 88%]
.....................................X.................................. [ 89%]
.....x.........xxxxx......xxXx......x......X.x.X..X.....X................ [ 90%]
...X...........X.........x......x...............X....................... [ 92%]
.............................x.......................................... [ 93%]
.................................................x...x.xxx....x.....x... [ 94%]
...x......x...........xx...........x.........x....................xx.... [ 96%]
.x..............................................x.........X..X.......x.. [ 97%]
........................................................................ [ 98%]
..........................................................               [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml

= 5002 passed, 69 skipped, 176 xfailed, 152 xpassed, 9509 warnings in 114.40s (0:01:54) =

modin-bot · 2020-09-07T14:47:54Z

TeamCity Ray test results bot

Tests PASSed

Tests Logs

============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
collected 113 items

modin/pandas/test/test_io.py .................sx..........s............. [ 38%]
....................................s..s.X.....s..................ss..   [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml


= 104 passed, 7 skipped, 1 xfailed, 1 xpassed, 95 warnings in 84.68s (0:01:24) =
Closing remaining open files:test_write_pandas.hdf...donetest_write_modin.hdf...done
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I / gw8 I / gw9 I / gw10 I / gw11 I / gw12 I / gw13 I / gw14 I / gw15 I / gw16 I / gw17 I / gw18 I / gw19 I / gw20 I / gw21 I / gw22 I / gw23 I / gw24 I / gw25 I / gw26 I / gw27 I / gw28 I / gw29 I / gw30 I / gw31 I / gw32 I / gw33 I / gw34 I / gw35 I / gw36 I / gw37 I / gw38 I / gw39 I / gw40 I / gw41 I / gw42 I / gw43 I / gw44 I / gw45 I / gw46 I / gw47 I
[gw24] node down: Not properly terminated

replacing crashed worker gw24
gw0 [5399] / gw1 [5399] / gw2 [5399] / gw3 [5399] / gw4 [5399] / gw5 [5399] / gw6 [5399] / gw7 [5399] / gw8 [5399] / gw9 [5399] / gw10 [5399] / gw11 [5399] / gw12 [5399] / gw13 [5399] / gw14 [5399] / gw15 [5399] / gw16 [5399] / gw17 [5399] / gw18 [5399] / gw19 [5399] / gw20 [5399] / gw21 [5399] / gw22 [5399] / gw23 [5399] / gw48 [5399] / gw25 [5399] / gw26 [5399] / gw27 [5399] / gw28 [5399] / gw29 [5399] / gw30 [5399] / gw31 [5399] / gw32 [5399] / gw33 [5399] / gw34 [5399] / gw35 [5399] / gw36 [5399] / gw37 [5399] / gw38 [5399] / gw39 [5399] / gw40 [5399] / gw41 [5399] / gw42 [5399] / gw43 [5399] / gw44 [5399] / gw45 [5399] / gw46 [5399] / gw47 [5399]

.......................................................................... [  1%]
........................................................................ [  2%]
........................................................................ [  4%]
......................................................................... [  5%]
......................................................................... [  6%]
...............................................................x........ [  8%]
....................................................s...................x. [  9%]
.........x........�[2m�[36m(pid=7676)�[0m error: object directory /localdisk/tc_agent/system/git/git-CE4319E5.git/objects does not exist; check .git/objects/info/alternates.
�[2m�[36m(pid=7676)�[0m fatal: bad object HEAD
.........x....x........x.............................. [ 10%]
.....X...............xx.....x.......s.................x.................. [ 12%]
........x........x...................................................... [ 13%]
..x...x..............x..........X.....x......x.x.................x....... [ 14%]
...........x..........x..........................x...x......�[2m�[36m(pid=7931)�[0m error: object directory /localdisk/tc_agent/system/git/git-CE4319E5.git/objects does not exist; check .git/objects/info/alternates.
�[2m�[36m(pid=7931)�[0m fatal: bad object HEAD
.x.......... [ 16%]
................x..........................x........x.................... [ 17%]
..................................X......................x.............. [ 18%]
x........................................................................ [ 20%]
.......................................................................x [ 21%]
...................................X.....................x.............. [ 22%]
.............X................x.x..............................x........ [ 24%]
....................x...................xX............................... [ 25%]
..........................x.........x..................x......X......... [ 26%]
X...........X........X....X.....X......X................................ [ 28%]
..............x.....................................X...................X [ 29%]
x..................................x..............................x.X.... [ 30%]
.....X.........X.x......XX............................................... [ 32%]
..........x..............................................x...........x... [ 33%]
............X.......X.........X...........X............X............X... [ 34%]
.....................................xs............x..................x.. [ 36%]
.............................x..x...........x..x.......................X.... [ 37%]
.....x.......x.........................x.xX...............x...........X.. [ 39%]
.x......X...x........X...........X........X........x.X.XX...X..X......... [ 40%]
X................X.............X............x........................... [ 41%]
..............x......X.x..x...........................x................. [ 43%]
..................x........................x....X......................x [ 44%]
.....................xx.........X......XX.X.....X...x....Xx....s.s..ss.s. [ 45%]
..ss.s..ss....s..s....x...................................xs............ [ 47%]
..........................x..........................s..s.x.sx.s...Xsss.x. [ 48%]
...s.s.s.s...s..X.....X..x..X....s..s.s...s.s.ss.s...s..s..s............ [ 49%]
.....x...............................xX...X............................. [ 51%]
....x..................x............................xx..........XX...... [ 52%]
......X.x.....x..........X...........X....X..........x...............x... [ 53%]
..............xX......X....X....XX......X.....X..............s......x... [ 55%]
...................xxx..x..x..............x.x.....................s...x.. [ 56%]
......................x......................x....X...X.................. [ 57%]
.................x..................x.......................X........... [ 59%]
.....................x......................x.............x........x.... [ 60%]
xx....X.X..sX.s..xX..XX.X......X...X..X..xX...X...........x.............x [ 61%]
................x....................................................... [ 63%]
..............x........x....X.X.X...X.....XX.X......X....x............... [ 64%]
...x..........x........................x.....................x.......... [ 65%]
........................................................................ [ 67%]
....x..................................................x................ [ 68%]
........................................................................ [ 69%]
X........s................................s............................. [ 71%]
..............................................................X......... [ 72%]
........................................................................ [ 73%]
.................................................X...................... [ 75%]
..................s.........s.....s............................ss...s.�[2m�[36m(pid=9469)�[0m error: object directory /localdisk/tc_agent/system/git/git-CE4319E5.git/objects does not exist; check .git/objects/info/alternates.
�[2m�[36m(pid=9469)�[0m fatal: bad object HEAD
s. [ 76%]
......s..............s..s............s.s...s...................s...sx... [ 77%]
......s.s....s..........x.........ss..s.....x.x..s.x...x.......x....x... [ 79%]
.........s..............x.....................s...x............Xx....... [ 80%]
.....X...........X...X..X.X..........X......XXX....X.XX..x....X.X.x.x... [ 81%]
XX.....X..X.X.....XX........XX.X....................XX....XX........x..X [ 83%]
.XX....X....X.X........X...x...Xx..X...X...X...X.......X....X............. [ 84%]
...............................x....................X................... [ 85%]
............................X...X.X..................................... [ 87%]
..........................................................x..........X.. [ 88%]
.............X..............X...x........X......x....................x.. [ 89%]
......X..xX...x.X.x...x.......x..x........x...........x..........X...... [ 91%]
..................X..x.....x......x..............X..................X... [ 92%]
......x................x................................................ [ 93%]
........................x.x..x.x......................x...xx........x... [ 95%]
..x...x........xx...............x..................................x.... [ 96%]
..............x...........x............................................. [ 97%]
........................................................................ [ 99%]
.......................................                                  [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
---------------------- coverage: failed workers ----------------------
The following workers failed to return coverage data, ensure that pytest-cov is installed on these workers.
gw24
Coverage XML written to file coverage.xml

= 5002 passed, 69 skipped, 176 xfailed, 152 xpassed, 9475 warnings in 132.75s (0:02:12) =
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
collected 113 items

modin/pandas/test/test_io.py .................sx..........s............. [ 38%]
....................................s..s.X.....s..................ss..   [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml


= 104 passed, 7 skipped, 1 xfailed, 1 xpassed, 95 warnings in 84.68s (0:01:24) =
Closing remaining open files:test_write_pandas.hdf...donetest_write_modin.hdf...done
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.0.2, py-1.9.0, pluggy-0.13.1
rootdir: /modin, configfile: setup.cfg
plugins: cov-2.10.1, forked-1.2.0, xdist-2.1.0
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I / gw8 I / gw9 I / gw10 I / gw11 I / gw12 I / gw13 I / gw14 I / gw15 I / gw16 I / gw17 I / gw18 I / gw19 I / gw20 I / gw21 I / gw22 I / gw23 I / gw24 I / gw25 I / gw26 I / gw27 I / gw28 I / gw29 I / gw30 I / gw31 I / gw32 I / gw33 I / gw34 I / gw35 I / gw36 I / gw37 I / gw38 I / gw39 I / gw40 I / gw41 I / gw42 I / gw43 I / gw44 I / gw45 I / gw46 I / gw47 I
[gw24] node down: Not properly terminated

replacing crashed worker gw24
gw0 [5399] / gw1 [5399] / gw2 [5399] / gw3 [5399] / gw4 [5399] / gw5 [5399] / gw6 [5399] / gw7 [5399] / gw8 [5399] / gw9 [5399] / gw10 [5399] / gw11 [5399] / gw12 [5399] / gw13 [5399] / gw14 [5399] / gw15 [5399] / gw16 [5399] / gw17 [5399] / gw18 [5399] / gw19 [5399] / gw20 [5399] / gw21 [5399] / gw22 [5399] / gw23 [5399] / gw48 [5399] / gw25 [5399] / gw26 [5399] / gw27 [5399] / gw28 [5399] / gw29 [5399] / gw30 [5399] / gw31 [5399] / gw32 [5399] / gw33 [5399] / gw34 [5399] / gw35 [5399] / gw36 [5399] / gw37 [5399] / gw38 [5399] / gw39 [5399] / gw40 [5399] / gw41 [5399] / gw42 [5399] / gw43 [5399] / gw44 [5399] / gw45 [5399] / gw46 [5399] / gw47 [5399]

.......................................................................... [  1%]
........................................................................ [  2%]
........................................................................ [  4%]
......................................................................... [  5%]
......................................................................... [  6%]
...............................................................x........ [  8%]
....................................................s...................x. [  9%]
.........x........�[2m�[36m(pid=7676)�[0m error: object directory /localdisk/tc_agent/system/git/git-CE4319E5.git/objects does not exist; check .git/objects/info/alternates.
�[2m�[36m(pid=7676)�[0m fatal: bad object HEAD
.........x....x........x.............................. [ 10%]
.....X...............xx.....x.......s.................x.................. [ 12%]
........x........x...................................................... [ 13%]
..x...x..............x..........X.....x......x.x.................x....... [ 14%]
...........x..........x..........................x...x......�[2m�[36m(pid=7931)�[0m error: object directory /localdisk/tc_agent/system/git/git-CE4319E5.git/objects does not exist; check .git/objects/info/alternates.
�[2m�[36m(pid=7931)�[0m fatal: bad object HEAD
.x.......... [ 16%]
................x..........................x........x.................... [ 17%]
..................................X......................x.............. [ 18%]
x........................................................................ [ 20%]
.......................................................................x [ 21%]
...................................X.....................x.............. [ 22%]
.............X................x.x..............................x........ [ 24%]
....................x...................xX............................... [ 25%]
..........................x.........x..................x......X......... [ 26%]
X...........X........X....X.....X......X................................ [ 28%]
..............x.....................................X...................X [ 29%]
x..................................x..............................x.X.... [ 30%]
.....X.........X.x......XX............................................... [ 32%]
..........x..............................................x...........x... [ 33%]
............X.......X.........X...........X............X............X... [ 34%]
.....................................xs............x..................x.. [ 36%]
.............................x..x...........x..x.......................X.... [ 37%]
.....x.......x.........................x.xX...............x...........X.. [ 39%]
.x......X...x........X...........X........X........x.X.XX...X..X......... [ 40%]
X................X.............X............x........................... [ 41%]
..............x......X.x..x...........................x................. [ 43%]
..................x........................x....X......................x [ 44%]
.....................xx.........X......XX.X.....X...x....Xx....s.s..ss.s. [ 45%]
..ss.s..ss....s..s....x...................................xs............ [ 47%]
..........................x..........................s..s.x.sx.s...Xsss.x. [ 48%]
...s.s.s.s...s..X.....X..x..X....s..s.s...s.s.ss.s...s..s..s............ [ 49%]
.....x...............................xX...X............................. [ 51%]
....x..................x............................xx..........XX...... [ 52%]
......X.x.....x..........X...........X....X..........x...............x... [ 53%]
..............xX......X....X....XX......X.....X..............s......x... [ 55%]
...................xxx..x..x..............x.x.....................s...x.. [ 56%]
......................x......................x....X...X.................. [ 57%]
.................x..................x.......................X........... [ 59%]
.....................x......................x.............x........x.... [ 60%]
xx....X.X..sX.s..xX..XX.X......X...X..X..xX...X...........x.............x [ 61%]
................x....................................................... [ 63%]
..............x........x....X.X.X...X.....XX.X......X....x............... [ 64%]
...x..........x........................x.....................x.......... [ 65%]
........................................................................ [ 67%]
....x..................................................x................ [ 68%]
........................................................................ [ 69%]
X........s................................s............................. [ 71%]
..............................................................X......... [ 72%]
........................................................................ [ 73%]
.................................................X...................... [ 75%]
..................s.........s.....s............................ss...s.�[2m�[36m(pid=9469)�[0m error: object directory /localdisk/tc_agent/system/git/git-CE4319E5.git/objects does not exist; check .git/objects/info/alternates.
�[2m�[36m(pid=9469)�[0m fatal: bad object HEAD
s. [ 76%]
......s..............s..s............s.s...s...................s...sx... [ 77%]
......s.s....s..........x.........ss..s.....x.x..s.x...x.......x....x... [ 79%]
.........s..............x.....................s...x............Xx....... [ 80%]
.....X...........X...X..X.X..........X......XXX....X.XX..x....X.X.x.x... [ 81%]
XX.....X..X.X.....XX........XX.X....................XX....XX........x..X [ 83%]
.XX....X....X.X........X...x...Xx..X...X...X...X.......X....X............. [ 84%]
...............................x....................X................... [ 85%]
............................X...X.X..................................... [ 87%]
..........................................................x..........X.. [ 88%]
.............X..............X...x........X......x....................x.. [ 89%]
......X..xX...x.X.x...x.......x..x........x...........x..........X...... [ 91%]
..................X..x.....x......x..............X..................X... [ 92%]
......x................x................................................ [ 93%]
........................x.x..x.x......................x...xx........x... [ 95%]
..x...x........xx...............x..................................x.... [ 96%]
..............x...........x............................................. [ 97%]
........................................................................ [ 99%]
.......................................                                  [100%]

----------- coverage: platform linux, python 3.8.5-final-0 -----------
---------------------- coverage: failed workers ----------------------
The following workers failed to return coverage data, ensure that pytest-cov is installed on these workers.
gw24
Coverage XML written to file coverage.xml

= 5002 passed, 69 skipped, 176 xfailed, 152 xpassed, 9475 warnings in 132.75s (0:02:12) =

modin/backends/base/query_compiler.py

modin/backends/pandas/query_compiler.py

modin/pandas/dataframe.py

modin/backends/pandas/query_compiler.py

ienkovich · 2020-09-08T11:23:40Z

Thank you for your review! I pushed fixes for all issues you found.

devin-petersohn

I am comfortable with this approach. There are multiple ways we can make the implementation for these indexers faster, we need to create issues for them after this is merged.

modin/backends/pandas/query_compiler.py

YarShev · 2020-09-09T07:13:31Z

@ienkovich , LGTM! @devin-petersohn , are there any comments?

ienkovich · 2020-09-10T13:40:55Z

getitem_array seems to be a straightforward name since it implements getitem for an array key type. Can we proceed with that name for now? @devin-petersohn

devin-petersohn

One minor nit. Naming is okay with me!

modin/backends/pandas/query_compiler.py

ienkovich · 2020-09-11T16:41:08Z

@devin-petersohn Thanks for your review! I've pushed the final fix

Signed-off-by: ienkovich <ilya.enkovich@intel.com>

ienkovich · 2020-09-14T18:49:10Z

@devin-petersohn is it ok now?

devin-petersohn

Thanks for making the changes @ienkovich, LGTM!

…-project#2036) Signed-off-by: ienkovich <ilya.enkovich@intel.com>

ienkovich requested review from YarShev and devin-petersohn September 7, 2020 14:18

YarShev reviewed Sep 8, 2020

View reviewed changes

devin-petersohn reviewed Sep 8, 2020

View reviewed changes

modin/backends/pandas/query_compiler.py Outdated Show resolved Hide resolved

devin-petersohn requested changes Sep 11, 2020

View reviewed changes

modin/backends/pandas/query_compiler.py Outdated Show resolved Hide resolved

modin/backends/pandas/query_compiler.py Outdated Show resolved Hide resolved

REFACTOR-#2035: move getitem_array to the backend

61072c3

Signed-off-by: ienkovich <ilya.enkovich@intel.com>

ienkovich requested a review from devin-petersohn September 14, 2020 18:49

devin-petersohn approved these changes Sep 15, 2020

View reviewed changes

devin-petersohn merged commit 51ed0ae into modin-project:master Sep 15, 2020

aregm pushed a commit to aregm/modin that referenced this pull request Sep 16, 2020

REFACTOR-modin-project#2035: move getitem_array to the backend (modin…

af5216d

…-project#2036) Signed-off-by: ienkovich <ilya.enkovich@intel.com>

REFACTOR-#2035: move getitem_array to the backend #2036

REFACTOR-#2035: move getitem_array to the backend #2036

Uh oh!

Conversation

ienkovich commented Sep 7, 2020 • edited by YarShev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What do these changes do?

Uh oh!

modin-bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TeamCity Python test results bot

Tests PASSed

Uh oh!

codecov bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

modin-bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TeamCity Dask test results bot

Tests PASSed

Uh oh!

modin-bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TeamCity Ray test results bot

Tests PASSed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ienkovich commented Sep 8, 2020

Uh oh!

devin-petersohn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

YarShev commented Sep 9, 2020

Uh oh!

ienkovich commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-petersohn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ienkovich commented Sep 11, 2020

Uh oh!

ienkovich commented Sep 14, 2020

Uh oh!

devin-petersohn left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ienkovich commented Sep 7, 2020 •

edited by YarShev

Loading

modin-bot commented Sep 7, 2020 •

edited

Loading

codecov bot commented Sep 7, 2020 •

edited

Loading

modin-bot commented Sep 7, 2020 •

edited

Loading

modin-bot commented Sep 7, 2020 •

edited

Loading

ienkovich commented Sep 10, 2020 •

edited

Loading