Improve performance of slice indexing #1753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolves modin-project#1752 Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
devin-petersohn
changed the title
devin-petersohn
added
the
Performance 🚀
Codecov Report
@@ Coverage Diff @@
## master #1753 +/- ##
==========================================
+ Coverage 82.39% 84.10% +1.70%
==========================================
Files 77 77
Lines 7948 8007 +59
==========================================
+ Hits 6549 6734 +185
+ Misses 1399 1273 -126
Continue to review full report at Codecov.
|
|
|
|
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
anmyachev
approved these changes
Jul 21, 2020
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
* Improves performance of slice indexing * Resolves modin-project#1752 Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com> * Fix issue Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com> * Fix Series cases Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iloccan be 200x slower than__getitem__#1752KeyErrorwhen referencing to columns following by first #1728Signed-off-by: Devin Petersohn devin.petersohn@gmail.com
What do these changes do?
flake8 modinblack --check modingit commit -siloccan be 200x slower than__getitem__#1752added andpassing