Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance of iloc can be 200x slower than __getitem__ #1752

Closed
devin-petersohn opened this issue Jul 17, 2020 · 0 comments · Fixed by #1753
Closed

Performance of iloc can be 200x slower than __getitem__ #1752

devin-petersohn opened this issue Jul 17, 2020 · 0 comments · Fixed by #1753
Labels
Performance 🚀 Performance related issues and pull requests.

Comments

@devin-petersohn
Copy link
Collaborator

iloc and __getitem__ have dramatically different performance:

df.iloc[:, 0]
df[df.columns[0]]

The first can be as much as 200x slower. We must handle slices better internally for performance.
@devin-petersohn devin-petersohn added the Performance 🚀 Performance related issues and pull requests. label Jul 17, 2020
devin-petersohn added a commit to devin-petersohn/modin that referenced this issue Jul 17, 2020
@devin-petersohn
Improves performance of slice indexing
4afc988 
* Resolves modin-project#1752

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
@devin-petersohn devin-petersohn mentioned this issue Jul 17, 2020
Merged
5 tasks
anmyachev pushed a commit that referenced this issue Jul 21, 2020
@devin-petersohn
Improve performance of slice indexing (#1753)
c1aba38 
* Improves performance of slice indexing

* Resolves #1752

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>

* Fix issue

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>

* Fix Series cases

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
@devin-petersohn @aregm
Improve performance of slice indexing (modin-project#1753)
b78a628 
* Improves performance of slice indexing

* Resolves modin-project#1752

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>

* Fix issue

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>

* Fix Series cases

Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve performance of slice indexing devin-petersohn/modin
1 participant
@devin-petersohn