Skip to content

Additional bold italic detection#108

Merged
modesty merged 1 commit intomodesty:masterfrom
todorowww:master
Apr 22, 2017
Merged

Additional bold italic detection#108
modesty merged 1 commit intomodesty:masterfrom
todorowww:master

Conversation

@todorowww
Copy link
Contributor

I have updated the code to extend existing fix for issue #42 and added another detection - bolditalic fonts. So, when we don't have bold or italic set, and fonr identifies itself by "boldobl" in it's name, set bold and italic properties of the text.

It is possible that this doesn't cover all possible situations. This fix is made from my own situation where existing bold/italic detection has failed.

@modesty modesty merged commit d63de2d into modesty:master Apr 22, 2017
@modesty
Copy link
Owner

modesty commented Apr 22, 2017

thanks

modesty added a commit that referenced this pull request Nov 10, 2023
Additional bold italic detection
@luckymore
Copy link
Contributor

@modesty @todorowww
Hey, I found some cases, can we add these to bold and italic regexp?

VGDDOL+NimbusRomNo9L-Regu
DICEPX+NimbusRomNo9L-ReguItal
VGDDOL+NimbusRomNo9L-Regu
RPNZSV+NimbusMonL-Regu
ICBSQM+NimbusRomNo9L-Medi

@luckymore
Copy link
Contributor

And is it a typo here?

Should demi be medi?

const _boldSubNames = ['bd', 'bold', 'demi', 'black'];

@todorowww
Copy link
Contributor Author

And is it a typo here?

Should demi be medi?

const _boldSubNames = ['bd', 'bold', 'demi', 'black'];

No, not a typo, it's actually demi, meaning half-size. You can add all the cases you find that would improve detection, however, I haven't used this package in quite some time, so I can't really be of too much assistance.

@luckymore
Copy link
Contributor

Hmmmmm, got it, thanks for the reply, I'll submit a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants