-
Notifications
You must be signed in to change notification settings - Fork 391
Description
Dear Mr. Zhang,
The Italic field (TS[3]) is always zero regardless of whether the text field is Italic or not. After digging in pdffont.js for a bit, I figured out that it's because the value is always the initial value (false) set in the constructor and it is never set anywhere else.
In my case, I corrected the issue by making this very simple change to pdffont.js:
var _setFaceIndex = function() {
var fontObj = this.fontObj;
this.bold = fontObj.bold;
if (!this.bold) {
this.bold = this.typeName.indexOf("bold") >= 0 || this.typeName.indexOf("black") >= 0;
}
this.italic = fontObj.italic; // <---- Added this line only
Please note that Bold works as advertised. I notice that you are also analyzing the typeface name to distinguish between bold and normal text in the case of "pseudobold" text fonts, I have not done anything like that for italics so it probably won't work for typefaces that oblique by design but not by formatting.
I have not forked the project so please accept this issue and code snippet in lieu of a pull request. :)
Yours faithfully,
Riaan
PS. Thanks for the package, it's much appreciated!