-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerConverters.DCDC.HBridge #3897
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AHaumer
added
enhancement
New feature or enhancement
L: Electrical.PowerConverters
Issue addresses Modelica.Electrical.PowerConverters
labels
Nov 13, 2021
dietmarw
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good improvement. I've already rebased the branch onto master.
christiankral
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Critical/severe issue
enhancement
New feature or enhancement
L: Electrical.PowerConverters
Issue addresses Modelica.Electrical.PowerConverters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is backwards compatible as discussed in #3895 and documented in DCDC.HBridge and DCDC.Control.SignalPWM.
The new layout of distributing the the fire signals in the HBridge allows an alternative pwm algorithm, which - for triangular comparison signal - results in a much smaller current ripple (see Examples.DCDC.HBridge.HBridge_DC_Drive).
On the other hand, the old layout could cause a short circuit on the source (which is avoided by the new layout).