Skip to content

refactor(examples): use concurrently API for proper process cleanup #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ochafik merged 1 commit into from
Dec 11, 2025
Merged

refactor(examples): use concurrently API for proper process cleanup #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 27 additions & 66 deletions examples/run-all.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/

import { readdirSync, statSync, existsSync } from "fs";
import { spawn, type ChildProcess } from "child_process";
import concurrently from "concurrently";

const BASE_PORT = 3101;
const BASIC_HOST = "basic-host";
Expand All @@ -36,57 +36,9 @@ const command = process.argv[2];

if (!command || !COMMANDS.includes(command)) {
console.error(`Usage: bun examples/run-all.ts <${COMMANDS.join("|")}>`);

process.exit(1);
}

const processes: ChildProcess[] = [];

// Handle cleanup on exit
function cleanup() {
for (const proc of processes) {
proc.kill();
}
}
process.on("SIGINT", cleanup);
process.on("SIGTERM", cleanup);

// Spawn a process and track it
function spawnProcess(
cmd: string,
args: string[],
env: Record<string, string> = {},
prefix: string,
): ChildProcess {
const proc = spawn(cmd, args, {
env: { ...process.env, ...env },
stdio: ["ignore", "pipe", "pipe"],
});

proc.stdout?.on("data", (data) => {
const lines = data.toString().trim().split("\n");
for (const line of lines) {
console.log(`[${prefix}] ${line}`);
}
});

proc.stderr?.on("data", (data) => {
const lines = data.toString().trim().split("\n");
for (const line of lines) {
console.error(`[${prefix}] ${line}`);
}
});

proc.on("exit", (code) => {
if (code !== 0 && code !== null) {
console.error(`[${prefix}] exited with code ${code}`);
}
});

processes.push(proc);
return proc;
}

// Build the SERVERS environment variable (JSON array of URLs)
const serversEnv = JSON.stringify(servers.map((s) => s.url));

Expand All @@ -96,25 +48,34 @@ console.log(
);
console.log("");

// Build command list for concurrently
const commands: Parameters<typeof concurrently>[0] = [
// Server examples
...servers.map(({ dir, port }) => ({
command: `npm run --workspace examples/${dir} ${command}`,
name: dir,
env: { PORT: String(port) },
})),
// Basic host with SERVERS env
{
command: `npm run --workspace examples/${BASIC_HOST} ${command}`,
name: BASIC_HOST,
env: { SERVERS: serversEnv },
},
];

// If dev mode, also run the main library watcher
if (command === "dev") {
spawnProcess("npm", ["run", "watch"], {}, "lib");
commands.unshift({
command: "npm run watch",
name: "lib",
});
}

// Run each server example
for (const { dir, port } of servers) {
spawnProcess(
"npm",
["run", "--workspace", `examples/${dir}`, command],
{ PORT: String(port) },
dir,
);
}
const { result } = concurrently(commands, {
prefix: "name",
// For build command, we want all to complete; for start/dev, kill all on failure
killOthersOnFail: command !== "build",
});

// Run basic-host with the SERVERS env var
spawnProcess(
"npm",
["run", "--workspace", `examples/${BASIC_HOST}`, command],
{ SERVERS: serversEnv },
BASIC_HOST,
);
result.catch(() => process.exit(1));
Loading