refactor(examples): use concurrently API for proper process cleanup #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
examples/run-all.tswith concurrently's programmatic APInpm run examples:startwith Ctrl+CProblem
The custom
spawn()+proc.kill()cleanup didn't kill grandchildren processes:Solution
Use concurrently's API which handles process tree killing via tree-kill internally:
Test plan
npm run examples:buildworksnpm run examples:start+ Ctrl+C → no zombie processes on ports 3101-3108🤖 Generated with Claude Code