Skip to content

Improve progress reporting #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

stephentoub
Copy link
Contributor

@stephentoub stephentoub commented Mar 30, 2025

  • Enable injecting an IProgress<ProgressNotificationValue> into a tool call to report progress when the client has supplied a progress token
  • Add a custom type for ProgressToken and ProgressNotification to map to the schema
  • Simplify RequestId to match ProgressToken's shape
  • Serialize StdioClientTransport's SendMessageAsync implementation
  • Add strongly-typed names for all request methods
  • Change all request IDs created by McpJsonRpcEndpoint to include a guid for that endpoint

Closes #111
Closes #88

Copy link
Collaborator

@PederHP PederHP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good stuff in this one.

@stephentoub stephentoub force-pushed the improveprogress branch 5 times, most recently from 7f5ec50 to 935ff1e Compare March 31, 2025 02:52
- Enable injecting an `IProgress<>` into a tool call to report progress when the client has supplied a progress token
- Add a custom type for ProgressToken and ProgressNotification to map to the schema
- Simplify RequestId to match ProgressToken's shape
- Serialize StdioClientTransport's SendMessageAsync implementation
- Add strongly-typed names for all request methods
- Change all request IDs created by McpJsonRpcEndpoint to include a guid for that endpoint
@stephentoub stephentoub merged commit 2c75acd into modelcontextprotocol:main Mar 31, 2025
8 checks passed
@stephentoub stephentoub deleted the improveprogress branch March 31, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement to support IProgress Expected usage for concurrent calls
3 participants