Skip to content

fix: preserve TypeScript compilation errors instead of masking as MOD… #5557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −0
Open

fix: preserve TypeScript compilation errors instead of masking as MOD… #5557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions lib/nodejs/esm-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,20 @@ const tryImportAndRequire = async (file, esmDecorator) => {
try {
return dealWithExports(await formattedImport(file, esmDecorator));
} catch (err) {
// Check if this is a TypeScript compilation error (from ts-node or similar)
// These often have detailed diagnostic information that we should preserve
const isTypescriptError =
err.message &&
(err.message.includes("TS") ||
err.message.includes("TypeScript") ||
err.message.includes("Type '") ||
/:\(\d+,\d+\):/.test(err.message)); // TypeScript error format like (line,col)

// If it's likely a TypeScript compilation error, don't mask it with fallback attempts
if (isTypescriptError && err.code === "ERR_MODULE_NOT_FOUND") {
throw err;
}

if (
err.code === "ERR_MODULE_NOT_FOUND" ||
err.code === "ERR_UNKNOWN_FILE_EXTENSION" ||
Expand Down Expand Up @@ -98,6 +112,21 @@ const requireModule = async (file, esmDecorator) => {
return require(file);
} catch (requireErr) {
debug("requireModule caught err: %O", requireErr.message);

// Check if this is a TypeScript compilation error (from ts-node or similar)
// These often have detailed diagnostic information that we should preserve
const isTypescriptError =
requireErr.message &&
(requireErr.message.includes("TS") ||
requireErr.message.includes("TypeScript") ||
requireErr.message.includes("Type '") ||
/:\(\d+,\d+\):/.test(requireErr.message)); // TypeScript error format like (line,col)

// If it's a TypeScript compilation error, throw it immediately without trying import()
if (isTypescriptError) {
throw requireErr;
}

try {
return dealWithExports(await formattedImport(file, esmDecorator));
} catch (importErr) {
Expand Down