fix: preserve TypeScript compilation errors instead of masking as MOD… #5557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5555
When ts-node or similar TypeScript compilers encounter a type error,
the error was being caught and masked by fallback module loading logic,
resulting in unhelpful "Cannot find module" messages instead of the
actual TypeScript diagnostics.
This fix detects TypeScript compilation errors by checking for TS-specific
patterns in error messages and throws them immediately without attempting
fallback mechanisms, preserving the full diagnostic information for users.
Fixes issue where TypeScript errors in imported modules showed as
"Cannot find module" rather than displaying the actual type error.