-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Closed
Labels
area: repository toolingconcerning ease of contributionconcerning ease of contributionstatus: accepting prsMocha can use your help with this one!Mocha can use your help with this one!
Description
Tooling Suggestion Checklist
- I have tried restarting my IDE and the issue persists.
- I have pulled the latest
mainbranch of the repository. - I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
- I have searched for related issues and issues with the
faqlabel, but none matched my issue. - I want to provide a PR to resolve this
Overview
Mocha has a devDependency right now on a 5-year-old version of nyc:
Line 162 in b2985b3
| "nyc": "^15.1.0", |
This isn't a problem on its own. nyc@15 works as-is. But it pulls in old dependencies that bloat our local node_modules size. For example, in #5482, we see it pulling in supports-color@5 inside some older @babel/* packages:
└─┬ nyc@15.1.0
└─┬ istanbul-lib-instrument@4.0.3
└─┬ @babel/core@7.21.3
└─┬ @babel/code-frame@7.22.13
├─┬ @babel/highlight@7.22.20
│ └─┬ chalk@2.4.2
│ └── supports-color@5.5.0
└─┬ chalk@2.4.2
└── supports-color@5.5.0
I think it'd be a good idea in general to bump it to the latest major version.
Additional Info
In theory it'd be nice to automatically upgrade all devDependencies. #5055 is blocked for now: #5055 (comment).
No relevant breaking changes, only minimum Node version now being 18: https://github.com/istanbuljs/nyc/blob/main/CHANGELOG.md
💖
mark-wiemer and hainenber
Metadata
Metadata
Assignees
Labels
area: repository toolingconcerning ease of contributionconcerning ease of contributionstatus: accepting prsMocha can use your help with this one!Mocha can use your help with this one!
Type
Projects
Status
Done