Skip to content

Conversation

@hainenber
Copy link

PR Checklist

Overview

Bump nyc dev dep from v15 to v17. There's no breaking change between these major versions except dropping Node 18 supports which mocha already did.

Signed-off-by: hainenber <dotronghai96@gmail.com>
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (a7c7eb2) to head (1353e34).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5556      +/-   ##
==========================================
- Coverage   93.69%   93.52%   -0.18%     
==========================================
  Files          57       57              
  Lines        4396     4465      +69     
  Branches      849      918      +69     
==========================================
+ Hits         4119     4176      +57     
- Misses        277      289      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks!

We can ignore the coverage report, that's #5558. It's good that this change reduced the package-lock.json size. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🛠 Repo: Bump nyc from 15 to 17

2 participants