Skip to content

Eliminate shell scripts from Mocha's test suite #2805

Closed

Description

Besides getting ourselves off the Makefile (#2268?), the other thing that doesn't work on a default Windows development environment is Unix/Linux shell scripts. (Even with a Posixy environment, they can have problems with line endings like #2801; this would not be an issue if they weren't Posixy shell scripts in the first place.) As far as I am aware, Node's child_process actions can run anything in a shell the same as if it were in a .sh script, so we should be able to convert any such test files to proper JS test files.

The one of these of which I am aware is:

  • test/acceptance/glob/glob.sh

(We can make an exception for scripts used only by CI and not local test runs, of course.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    status: accepting prsMocha can use your help with this one!type: choregenerally involving deps, tooling, configuration, etc.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions