Skip to content

Line endings and test files #2801

Closed
Closed

Description

Similar to #2800, while the test suite can be run on Windows (e.g. using MinGW make with either Cygwin or Git Shell), certain tests fail if certain files do not have the right line endings:

  • test/acceptance/glob/glob.sh -- this just needs to be Linux line endings, should probably be converted to them by the test run if possible regardless of how they may have been changed
  • something in test/integration/fixtures/diff -- perhaps just the output file? and not sure if the right line endings here are always Linux, or depend on the OS, or depend on whether the tests are being run from a Posixy environment (as is necessary to use the Makefile)

More meta-like, if this ends up requiring per-file fiddling, then it would be really, really helpful to have some way of guaranteeing that our CI runs won't succeed just because they happen to have the right global settings that developers may or may not have. It doesn't make sense to have something that we need to set up correctly for certain tests that won't fail CI if we get it wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    status: accepting prsMocha can use your help with this one!type: choregenerally involving deps, tooling, configuration, etc.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions