Use unix.Ioctl{Get,Set}Termios on all unix platforms#16
Merged
cpuguy83 merged 2 commits intomoby:masterfrom Sep 11, 2020
Merged
Use unix.Ioctl{Get,Set}Termios on all unix platforms#16cpuguy83 merged 2 commits intomoby:masterfrom
cpuguy83 merged 2 commits intomoby:masterfrom
Conversation
tklauser
force-pushed
the
unix-termios
branch
2 times, most recently
from
bbf349e to
879576f
Compare
Member
|
@kolyshkin @cpuguy83 PTAL |
kolyshkin
reviewed
Sep 8, 2020
kolyshkin
reviewed
Sep 8, 2020
kolyshkin
reviewed
Sep 8, 2020
Unify the implementation for all unix platforms to use IoctlGetTermios and IoctlSetTermios from the golang.org/x/sys/unix package instead of implementing it in terms of SYS_IOCTL. This avoids duplicating code, makes error handling easier and fixes the build on darwin where direct syscalls, i.e. unix.Syscall(SYS_IOCTL, ...) are no longer allowed and exported as of golang/sys@6fcdbc0bbc04 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
unix-termios
branch
from
879576f to
03600fb
Compare
Contributor
Author
|
Thanks for the review @kolyshkin! Changed according to your comments, PTAL. |
|
@kolyshkin — is this good to merge? I'd love to see it merged. |
|
Thanks 👍 |
justincormack
approved these changes
Sep 11, 2020
This was referenced Sep 15, 2020
5 tasks
This was referenced Oct 15, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify the implementation for all unix platforms to use IoctlGetTermios
and IoctlSetTermios from the golang.org/x/sys/unix package instead of
implementing it in terms of SYS_IOCTL. This avoids duplicating code,
makes error handling easier and fixes the build on darwin where direct
syscalls, i.e. unix.Syscall(SYS_IOCTL, ...) are no longer allowed and
exported as of golang/sys@6fcdbc0bbc04
Also fix a build issue with
GOOS=solarisand bump thegolang.org/x/sys/unix dependency.
/cc @thaJeztah