Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Fix build issue on macOS in github.com/docker/docker/pkg/term#2

Closed
jamesjoshuahill wants to merge 1 commit intomasterfrom
jh-fix-darwin-build
Closed

Fix build issue on macOS in github.com/docker/docker/pkg/term#2
jamesjoshuahill wants to merge 1 commit intomasterfrom
jh-fix-darwin-build

Conversation

@jamesjoshuahill
Copy link

@jamesjoshuahill jamesjoshuahill commented Nov 6, 2020

Why

The current version of github.com/docker/docker/pkg/term is affected by a build issue on Darwin. This occurs when a Go module depends on a version of golang.org/x/sys more recent than 6fcdbc0, see moby/term#15.

Let's enable consumers of this module to build on Darwin with the latest version of golang.org/x/sys by updating the dependency.

What

  • Update dependencies to use latest version of github.com/moby/term package. This requires upgrading the version of github.com/moby/moby to at least v20.10.0-beta1, which includes 8312004.
  • Ensure make test succeeds.
  • Run tests in CI.

Notes:

@jamesjoshuahill jamesjoshuahill marked this pull request as draft November 6, 2020 14:03
- This version replaces the deprecated moby/moby/pkg/term package with
moby/term.
- The latest version of moby/term fixes a build issue on Darwin:
moby/term#15.
@jamesjoshuahill jamesjoshuahill changed the title Update to use github.com/moby/term package Update to fix Darwin build issue in github.com/docker/docker/pkg/term Nov 6, 2020
@jamesjoshuahill jamesjoshuahill changed the title Update to fix Darwin build issue in github.com/docker/docker/pkg/term Fix Darwin build issue in github.com/docker/docker/pkg/term Nov 6, 2020
@jamesjoshuahill jamesjoshuahill changed the title Fix Darwin build issue in github.com/docker/docker/pkg/term Fix build issue on macOS in github.com/docker/docker/pkg/term Nov 6, 2020
@jamesjoshuahill
Copy link
Author

Upgrading moby/moby from v17.x -> v20.x is not trivial. Closing in favour of removing the dependency on this unmaintained package.

A workaround for consumers of this package is to pin golang/x/sys to the commit before the constants were removed: moby/term#15 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants