This repository was archived by the owner on Mar 15, 2024. It is now read-only.
Fix build issue on macOS in github.com/docker/docker/pkg/term#2
Closed
jamesjoshuahill wants to merge 1 commit intomasterfrom
Closed
Fix build issue on macOS in github.com/docker/docker/pkg/term#2jamesjoshuahill wants to merge 1 commit intomasterfrom
jamesjoshuahill wants to merge 1 commit intomasterfrom
Conversation
stoovon
approved these changes
Nov 6, 2020
e99f328 to
76dd5c6
Compare
- This version replaces the deprecated moby/moby/pkg/term package with moby/term. - The latest version of moby/term fixes a build issue on Darwin: moby/term#15.
76dd5c6 to
cddfaa6
Compare
Author
|
Upgrading moby/moby from v17.x -> v20.x is not trivial. Closing in favour of removing the dependency on this unmaintained package. A workaround for consumers of this package is to pin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The current version of
github.com/docker/docker/pkg/termis affected by a build issue on Darwin. This occurs when a Go module depends on a version ofgolang.org/x/sysmore recent than6fcdbc0, see moby/term#15.Let's enable consumers of this module to build on Darwin with the latest version of
golang.org/x/sysby updating the dependency.What
github.com/moby/termpackage. This requires upgrading the version ofgithub.com/moby/mobyto at leastv20.10.0-beta1, which includes8312004.make testsucceeds.Notes:
github.com/docker/dockerwas renamed togithub.com/moby/moby.github.com/docker/docker/pkg/termis deprecated. Usegithub.com/moby/terminstead.github.com/moby/mobyremoved usages of the deprecatedgithub.com/docker/docker/pkg/termpackage in8312004.