Skip to content

ci: fix target for rootless image #6463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonistiigi merged 1 commit into from
Jan 14, 2026
Merged

ci: fix target for rootless image #6463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/buildkit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ jobs:
push: ${{ github.repository == 'moby/buildkit' && (github.event_name == 'schedule' || github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags/v')) }}
sbom: true
set: |
*.args.IMAGE_TARGET=${{ matrix.target }}
*.target=${{ matrix.target }}
*.args.EXPORT_BASE=${{ matrix.base }}
*.args.BUILDKITD_TAGS=${{ matrix.buildTags }}
Copy link
Member

@AkihiroSuda AkihiroSuda Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use env vars

Copy link
Member Author

@crazy-max crazy-max Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reusable workflows don't support the env object, and due to the isolation guarantees of the Docker GitHub Builder, we can't allow users to arbitrarily alter the runner environment. We might be able to support envs using a new input in the bake reusable workflow that would be only attached to buildx process.

Copy link
Member

@tonistiigi tonistiigi Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should still be possible the set values for the variables of bake builds. These should not become env in the rest of the workflow, just passed to bake.

Or should we add smth like --var k=v in bake that can be used as an alternative way to set values instead of putting them in the env, together with BUILDX_BAKE_NO_ENV_ACCESS to make sure bake doesn't access some env that is defined by default?

set-meta-annotations: true
Expand Down