Skip to content

Comments

ci: fix target for rootless image#6463

Merged
tonistiigi merged 1 commit intomoby:masterfrom
crazy-max:fix-rootless-image
Jan 14, 2026
Merged

ci: fix target for rootless image#6463
tonistiigi merged 1 commit intomoby:masterfrom
crazy-max:fix-rootless-image

Conversation

@crazy-max
Copy link
Member

fixes #6457

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max added this to the v0.27.0 milestone Jan 14, 2026
*.args.IMAGE_TARGET=${{ matrix.target }}
*.target=${{ matrix.target }}
*.args.EXPORT_BASE=${{ matrix.base }}
*.args.BUILDKITD_TAGS=${{ matrix.buildTags }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use env vars

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reusable workflows don't support the env object, and due to the isolation guarantees of the Docker GitHub Builder, we can't allow users to arbitrarily alter the runner environment. We might be able to support envs using a new input in the bake reusable workflow that would be only attached to buildx process.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should still be possible the set values for the variables of bake builds. These should not become env in the rest of the workflow, just passed to bake.

Or should we add smth like --var k=v in bake that can be used as an alternative way to set values instead of putting them in the env, together with BUILDX_BAKE_NO_ENV_ACCESS to make sure bake doesn't access some env that is defined by default?

@crazy-max crazy-max marked this pull request as ready for review January 14, 2026 12:05
@tonistiigi tonistiigi merged commit 5068904 into moby:master Jan 14, 2026
190 checks passed
@crazy-max crazy-max deleted the fix-rootless-image branch January 14, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

moby/buildkit:master-rootless just stop working

3 participants