Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple fixes for ONBUILD behavior #5397

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Multiple fixes for ONBUILD behavior #5397

merged 3 commits into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. dockerfile: fix command count after new commands from ONBUILD 

    Fix progress lines like `[6/4] step`

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
    @tonistiigi
    tonistiigi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ec8d92f View commit details
    Browse the repository at this point in the history

  2. dockerfile: mark commands invoked from ONBUILD with prefix 

    Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
    @tonistiigi
    tonistiigi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f1f24dc View commit details
    Browse the repository at this point in the history

  3. dockerfile: set error location for ONBUILD errors 

    Set error location for ONBUILD errors to the command
that pulled in the image with ONBUILD definitions.

Currently location was incorrectly set to the first
line as ONBUILD was parsed as a separate source code.

Location is handled both at parse time (for invalid
ONBUILD definition) and run time (when command set
via ONBUILD errors).

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
    @tonistiigi
    tonistiigi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    811ff73 View commit details
    Browse the repository at this point in the history