Multiple fixes for ONBUILD behavior #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix progress lines like `[6/4] step` Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Set error location for ONBUILD errors to the command that pulled in the image with ONBUILD definitions. Currently location was incorrectly set to the first line as ONBUILD was parsed as a separate source code. Location is handled both at parse time (for invalid ONBUILD definition) and run time (when command set via ONBUILD errors). Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
dvdksn
approved these changes
Oct 4, 2024
crazy-max
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dockerfile: fix command count after new commands from ONBUILD
Fix progress lines like
[6/4] stepdockerfile: mark commands invoked from ONBUILD with prefix
dockerfile: set error location for ONBUILD errors
Set error location for ONBUILD errors to the command
that pulled in the image with ONBUILD definitions.
Currently location was incorrectly set to the first
line as ONBUILD was parsed as a separate source code.
Location is handled both at parse time (for invalid
ONBUILD definition) and run time (when command set
via ONBUILD errors).