URL does not get converted from snake_case responder_url to camelCase responderURL #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proelke
reviewed
Feb 5, 2024
| @@ -54,6 +54,8 @@ def snake_to_camel_case(data): | |||
| for key, value in data.items(): | |||
| key = key.replace("soc", "SoC") | |||
| key = key.replace("_v2x", "V2X") | |||
| key = key.replace("_url", "URL") | |||
There was a problem hiding this comment.
The issue with this approach is another field, as I mentioned in my other PR. The ocppCsmsUrl field in a SetNetworkProfileRequest will fail due to this change. I would suggest adding test cases for any usage of URL in the spec.
There was a problem hiding this comment.
I believe these are all attributes that include url:
$ grep -i "url" ocpp/v201/*.py
ocpp/v201/datatypes.py: ocpp_csms_url: str
ocpp/v201/datatypes.py: responder_url: str
ocpp/v201/enums.py: invalid_url = "InvalidURL"
…-responder_url-to-camelCase-responderURL
OrangeTux
approved these changes
Feb 6, 2024
OrangeTux
requested changes
Feb 6, 2024
…snake_case-responder_url-to-camelCase-responderURL' into URL-does-not-get-converted-from-snake_case-responder_url-to-camelCase-responderURL
|
This should now be complete - @proelke does this cover everything? |
…-responder_url-to-camelCase-responderURL
…-responder_url-to-camelCase-responderURL
OrangeTux
previously approved these changes
Feb 13, 2024
…-responder_url-to-camelCase-responderURL
Jared-Newell-Mobility
deleted the
URL-does-not-get-converted-from-snake_case-responder_url-to-camelCase-responderURL
branch
Jared-Newell-Mobility
added a commit
that referenced
this pull request
Apr 25, 2024
- OCPP v1.6/v2.0.1 deprecate dataclasses from calls and call results with the suffix 'Payload' by @Jared-Newell-Mobility in #584 - In GA, validate project against Python 3.11 and 3.12. by @Jared-Newell-Mobility in #589 - drop support for python 3.7 by @Jared-Newell-Mobility in #585 - Update Code Owners by @Jared-Newell-Mobility in #588 - Revert "drop support for python 3.7" by @Jared-Newell-Mobility in #597 - OCPP 2.0.1 Wrong data type in CostUpdated total_cost by @Jared-Newell-Mobility in #596 - Update tests to use Call and CallResult without the suffix Payload by @Jared-Newell-Mobility in #595 - Fix camel_to_snake_case for "v2x" by @Jared-Newell-Mobility in #594 - Correct naming of members of v201.enums.AttributeType by @Jared-Newell-Mobility in #578 - Drop support for python 3.7 by @Jared-Newell-Mobility in #598 - Remove v1.6 deprecated enum variants by @Jared-Newell-Mobility in #575 - Typo in CostUpdated Action #435 by @Jared-Newell-Mobility in #491- - Remove support for ocpp 2.0 by @Jared-Newell-Mobility in #576 - v201.datatypes.ChargingNeedsType.request_energy_transfer is mistyped by @Jared-Newell-Mobility in #496 - v201.enums.StatusInfoReasonType.invaild_schedule by @Jared-Newell-Mobility in #521 - update to match Appendix 2. Standardized Units Of Measure by @Jared-Newell-Mobility in #512 - v16/schemas/StopTransaction.json missing "Hertz" #207 by @Jared-Newell-Mobility in #497 - Correct v2g serialisation/deserialisation by @Jared-Newell-Mobility in #606 - 2.0.1 dataclasses have a incorrect types that don't match carnality by @Jared-Newell-Mobility in #529 - Readthedocs_configuration_is_outdated by @Jared-Newell-Mobility in #608 - Readthedocs_configuration_is_outdated_config_update by @Jared-Newell-Mobility in #609 - The serialisation of soc to SoC should not occur in camel case if it is existing at the beginning of a field by @Jared-Newell-Mobility in #527 - Fix case conversion for soc in non "State of Charge" context by @Jared-Newell-Mobility in #607 - Handle recursively serializing a dataclasses as a dictionary. by @Jared-Newell-Mobility in #547 - v2.0.1 Action enums corrected by @Jared-Newell-Mobility in #580 - URL does not get converted from snake_case responder_url to camelCase responderURL by @Jared-Newell-Mobility in #592 - v1.6 Action Enum members corrected by @Jared-Newell-Mobility in #600 - Introduce Experimental Module For v2.1 by @Jared-Newell-Mobility in #605 - Bump to 1.0.0-rc.1 by @Jared-Newell-Mobility in #611 - fix typo in DataTypeEnum -> value_too_high by @d2avids in #612 - fix typo CostUpdated enum for 201 by @OSkrk in #620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #590