Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v16/schemas/StopTransaction.json missing "Hertz" #207

Closed
villekr opened this issue Apr 26, 2021 · 6 comments
Closed

v16/schemas/StopTransaction.json missing "Hertz" #207

villekr opened this issue Apr 26, 2021 · 6 comments
Labels
bug Something isn't working For inclusion in release 1.0.0

Comments

@villekr
Copy link
Contributor

villekr commented Apr 26, 2021

In issue #71 "Hertz" was added as valid unit. However it should also be allowed within StopTransaction's transactionData.
@villekr
Copy link
Contributor Author

villekr commented Apr 27, 2021

After checking the referred document "OCPP 1.6 Errata sheet, v4.0 Release, 2019-10-23, on page 33" I think that change done in #71 might be incorrect. The document doesn't specify that unit "Hertz" should be explicitly defined and allowed in schema. Latest official ocpp 1.6 schemas for Metervalues.json and StopTransaction.json don't have "Hertz" as enumeration for "unit".

Document: OCPP 1.6 Errata sheet, v4.0 Release, 2019-10-23, on page 33:
OCPP 1.6 does not have a UnitOfMeasure for frequency, the UnitOfMeasure for any SampledValue with measurand: Frequency is Hertz.

The question is that should change #71 (22306f0) be actually reverted?

@OrangeTux
Copy link
Collaborator

Good catch. I think you're right and Hertz has not been added as a Unit. However, reverting the change would be backwards incompatible.

@villekr
Copy link
Contributor Author

villekr commented Apr 27, 2021

Would it still be better to fix (i.e. revert) instead of keeping incorrect enum and schema there? Now it's possible to send non-standard MeterValues messages.

@OrangeTux
Copy link
Collaborator

I think you're right. Given that we're currently before a 1.x.x. release, this package can have backwards incompatible changes according to SemVer. I'll revert the change soon.

@Jared-Newell-Mobility Jared-Newell-Mobility added the bug Something isn't working label Sep 7, 2023
@Jared-Newell-Mobility
Copy link
Contributor

Satisfied with PR #497 - will be included in next major release

Closed
26 tasks
@Jared-Newell-Mobility
Copy link
Contributor

Referenced in #174

Jared-Newell-Mobility added a commit that referenced this issue Feb 7, 2024
@Jared-Newell-Mobility
v16/schemas/StopTransaction.json missing "Hertz" #207 (#497)
7f1d59e
Jared-Newell-Mobility added a commit that referenced this issue Apr 25, 2024
@Jared-Newell-Mobility
Bump 1.0.0 (#623)
cfe4008 
- OCPP v1.6/v2.0.1 deprecate dataclasses from calls and call results with the suffix 'Payload' by @Jared-Newell-Mobility in #584
- In GA, validate project against Python 3.11 and 3.12. by @Jared-Newell-Mobility in #589
- drop support for python 3.7 by @Jared-Newell-Mobility in #585
- Update Code Owners by @Jared-Newell-Mobility in #588
- Revert "drop support for python 3.7" by @Jared-Newell-Mobility in #597
- OCPP 2.0.1 Wrong data type in CostUpdated total_cost by @Jared-Newell-Mobility in #596
- Update tests to use Call and CallResult without the suffix Payload by @Jared-Newell-Mobility in #595
- Fix camel_to_snake_case for "v2x" by @Jared-Newell-Mobility in #594
- Correct naming of members of v201.enums.AttributeType by @Jared-Newell-Mobility in #578
- Drop support for python 3.7 by @Jared-Newell-Mobility in #598
- Remove v1.6 deprecated enum variants by @Jared-Newell-Mobility in #575
- Typo in CostUpdated Action #435 by @Jared-Newell-Mobility in #491-
- Remove support for ocpp 2.0 by @Jared-Newell-Mobility in #576
- v201.datatypes.ChargingNeedsType.request_energy_transfer is mistyped by @Jared-Newell-Mobility in #496
- v201.enums.StatusInfoReasonType.invaild_schedule by @Jared-Newell-Mobility in #521
- update to match Appendix 2. Standardized Units Of Measure by @Jared-Newell-Mobility in #512
- v16/schemas/StopTransaction.json missing "Hertz" #207 by @Jared-Newell-Mobility in #497
- Correct v2g serialisation/deserialisation by @Jared-Newell-Mobility in #606
- 2.0.1 dataclasses have a incorrect types that don't match carnality by @Jared-Newell-Mobility in #529
- Readthedocs_configuration_is_outdated by @Jared-Newell-Mobility in #608
- Readthedocs_configuration_is_outdated_config_update by @Jared-Newell-Mobility in #609
- The serialisation of soc to SoC should not occur in camel case if it is existing at the beginning of a field by @Jared-Newell-Mobility in #527
- Fix case conversion for soc in non "State of Charge" context by @Jared-Newell-Mobility in #607
- Handle recursively serializing a dataclasses as a dictionary. by @Jared-Newell-Mobility in #547
- v2.0.1 Action enums corrected by @Jared-Newell-Mobility in #580
- URL does not get converted from snake_case responder_url to camelCase responderURL by @Jared-Newell-Mobility in #592
- v1.6 Action Enum members corrected by @Jared-Newell-Mobility in #600
- Introduce Experimental Module For v2.1 by @Jared-Newell-Mobility in #605
- Bump to 1.0.0-rc.1 by @Jared-Newell-Mobility in #611
- fix typo in DataTypeEnum -> value_too_high by @d2avids in #612
- fix typo CostUpdated enum for 201 by @OSkrk in #620
@drc38 drc38 mentioned this issue May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working For inclusion in release 1.0.0
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OrangeTux @villekr @Jared-Newell-Mobility