Skip to content

FIX: brain save_movie #9426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsoner merged 5 commits into from
May 27, 2021
Merged

FIX: brain save_movie #9426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e011f0
Fix
GuillaumeFavelier May 25, 2021
81a5769
Use filename
GuillaumeFavelier May 25, 2021
c954fac
Fix docstring
GuillaumeFavelier May 26, 2021
55c8089
Use ffprobe
GuillaumeFavelier May 26, 2021
a9c4a29
Use imageio_ffmpeg
GuillaumeFavelier May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions mne/viz/_brain/_brain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,7 +1261,9 @@ def _configure_tool_bar(self):
self._renderer._tool_bar_add_file_button(
name="movie",
desc="Save movie...",
func=self.save_movie,
func=lambda filename: self.save_movie(
filename=filename,
time_dilation=(1. / self.playback_speed)),
shortcut="ctrl+shift+s",
)
self._renderer._tool_bar_add_button(
Expand Down Expand Up @@ -3081,12 +3083,9 @@ def frame_callback(frame, n_frames):
self._renderer._window_new_cursor("WaitCursor"))

try:
self._save_movie(
filename=filename,
time_dilation=(1. / self.playback_speed),
callback=frame_callback,
**kwargs
)
self._save_movie(filename, time_dilation, tmin, tmax,
framerate, interpolation, codec,
bitrate, frame_callback, time_viewer, **kwargs)
except (Exception, KeyboardInterrupt):
warn('Movie saving aborted:\n' + traceback.format_exc())
finally:
Expand Down Expand Up @@ -3139,11 +3138,6 @@ def save_movie(self, filename=None, time_dilation=4., tmin=None, tmax=None,
%(brain_screenshot_time_viewer)s
**kwargs : dict
Specify additional options for :mod:`imageio`.

Returns
-------
dialog : object
The opened dialog is returned for testing purpose only.
"""
if filename is None:
filename = _generate_default_filename(".mp4")
Expand Down
11 changes: 9 additions & 2 deletions mne/viz/_brain/tests/test_brain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ def test_brain_save_movie(tmpdir, renderer, brain_gc):
"""Test saving a movie of a Brain instance."""
if renderer._get_3d_backend() == "mayavi":
pytest.skip('Save movie only supported on PyVista')
from imageio_ffmpeg import count_frames_and_secs
brain = _create_testing_brain(hemi='lh', time_viewer=False)
filename = str(path.join(tmpdir, "brain_test.mov"))
for interactive_state in (False, True):
Expand All @@ -403,9 +404,15 @@ def test_brain_save_movie(tmpdir, renderer, brain_gc):
brain.save_movie(filename, time_dilation=1, tmin=1, tmax=1.1,
bad_name='blah')
assert not path.isfile(filename)
brain.save_movie(filename, time_dilation=0.1,
interpolation='nearest')
tmin = 1
tmax = 5
duration = np.floor(tmax - tmin)
brain.save_movie(filename, time_dilation=1., tmin=tmin,
tmax=tmax, interpolation='nearest')
assert path.isfile(filename)
_, nsecs = count_frames_and_secs(filename)
assert_allclose(duration, nsecs, atol=0.2)

os.remove(filename)
brain.close()

Expand Down